Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Content in Single.php #1094

Closed
colin-marshall opened this issue Sep 29, 2017 · 2 comments
Closed

Content in Single.php #1094

colin-marshall opened this issue Sep 29, 2017 · 2 comments
Labels
Hacktoberfest

Comments

@colin-marshall
Copy link
Collaborator

Underscores and other themes control the content for both single pages and archive pages in template-parts/content.php using conditionals (like if is_single()).

In my opinion we should move the content out of single.php so we have one file controlling the content in both situations.
@JPOak
Copy link
Contributor

JPOak commented Sep 29, 2017

@colin-marshall I'm looking at trying to help out with a few things (cleanup etc). Should I just do a PR and you guys can review and reject as you see fit.

@colin-marshall
Copy link
Collaborator Author

@JPOak That would be great! Just make sure to separate the PR's out by bugfix or whatever topic they cover. Thanks!

@JPOak JPOak mentioned this issue Oct 2, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@olefredrik @colin-marshall @JPOak