Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trim routes for android - no more then 6 tabs #38

Conversation

mrpmohiburrahman
Copy link
Contributor

@mrpmohiburrahman mrpmohiburrahman commented Oct 12, 2024

This PR fixes issue #13

Right now it will show a warning if there are more than 6 tabs on android and will only show 6 tabs and trims the other tabs.

warning-when-more-than-6-tabs.mp4

src/TabView.tsx Outdated Show resolved Hide resolved
src/TabView.tsx Outdated Show resolved Hide resolved
src/TabView.tsx Outdated Show resolved Hide resolved
@mrpmohiburrahman
Copy link
Contributor Author

Hi, @okwasniewski ,
Thanks for the reviews.
I fixed those.

Copy link
Owner

@okwasniewski okwasniewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Great work 🙌

@mrpmohiburrahman
Copy link
Contributor Author

Thanks! Great work 🙌

I'm excited to contribute further.

Please let me know if there are any other issues I can assist with.

@okwasniewski okwasniewski merged commit caa5e7b into okwasniewski:main Oct 14, 2024
5 checks passed
@okwasniewski
Copy link
Owner

okwasniewski commented Oct 14, 2024

Thanks! Great work 🙌

I'm excited to contribute further.

Please let me know if there are any other issues I can assist with.

Awesome! This could be a good issue to work on next: #15 I'll try to create more soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants