Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to pass ClientSecret while configuring the client. #134

Open
CityHunter07 opened this issue Jun 8, 2023 · 2 comments
Open

Unable to pass ClientSecret while configuring the client. #134

CityHunter07 opened this issue Jun 8, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@CityHunter07
Copy link

Describe the bug?

Unable to pass ClientSecret while configuring the client, the previous way shows that it have been deprecated. Current configuration initialisation does not have a separate parameter to pass client secret in init. Sending Secret in "additionalParameters" might or might not work as authentication is getting completed even without client secret of user in private application.

What is expected to happen?

Need a configuration constructor that accepts client secret as a parameter. Authentication flow should not succeed without client secret.

What is the actual behavior?

Separate parameter for client secret is already provided in previous versions of SDK but now its deprecated. Need to add a parameter for client secret in client configuration.

Reproduction Steps?

  1. Create a private application in Okta tenent.
  2. Get client secret and client id from tenent settings.
  3. Add client id in "clientId" parameter and client secret in additional parameters in client configuration.
  4. Check if authentication flow is working fine.
  5. Now remove the additional parameters.
  6. Check if authentication flow is going fine.(It should not work - but its working)

Additional Information?

No response

SDK Version(s)

3.0.8

Build Information

No response

@CityHunter07 CityHunter07 added the bug Something isn't working label Jun 8, 2023
@CityHunter07
Copy link
Author

@mikenachbaur-okta Any Update on it??

@rajdeepnanua-okta
Copy link
Contributor

Hi @CityHunter07, @mikenachbaur-okta is working on this, but he is currently taking time off. He will update further once he is back from his time off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants