feat: Chunked execution of linters on Windows only #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #439 +/- ##
==========================================
+ Coverage 98.18% 98.71% +0.53%
==========================================
Files 11 12 +1
Lines 220 234 +14
Branches 25 27 +2
==========================================
+ Hits 216 231 +15
+ Misses 4 3 -1
Continue to review full report at Codecov.
|
okonet
previously approved these changes
May 2, 2018
Move some tests from makeCmdTasks to resolveTaskFn.
sudo-suhas
force-pushed
the
feat/chunk-only-on-win
branch
from
d9a4269
to
cde5d74
Compare
|
@okonet Adding the test commit dismissed your earlier review. Could you please take a look again? |
okonet
approved these changes
May 6, 2018
This was referenced May 7, 2018
This was referenced May 18, 2018
kornicameister
pushed a commit
to kornicameister/korni
that referenced
this pull request
May 23, 2018
## Overview The following dependencies have been updated by [dependencies.io](https://www.dependencies.io/): - `lint-staged` in `package.json` from "7.0.5" to "7.1.2" ## Details ### `lint-staged` This dependency is located in `package.json` and was updated from "7.0.5" to "7.1.2". <details> <summary>7.1.0</summary> # [7.1.0](lint-staged/lint-staged@v7.0.5...v7.1.0) (2018-05-07) ### Features * Chunked execution of linters on Windows only ([#439](lint-staged/lint-staged#439)) ([1601c02](lint-staged/lint-staged@1601c02)) </details> <details> <summary>7.1.1</summary> ## [7.1.1](lint-staged/lint-staged@v7.1.0...v7.1.1) (2018-05-18) ### Bug Fixes * **cli:** Correct value for FORCE_COLOR env var ([#451](lint-staged/lint-staged#451)) ([9823d26](lint-staged/lint-staged@9823d26)), closes [#448](lint-staged/lint-staged#448) </details> <details> <summary>7.1.2</summary> ## [7.1.2](lint-staged/lint-staged@v7.1.1...v7.1.2) (2018-05-21) ### Bug Fixes * **package:** Update cosmiconfig to version 5.0.2 ([#444](lint-staged/lint-staged#444)) ([2fc7aa3](lint-staged/lint-staged@2fc7aa3)), closes [#441](lint-staged/lint-staged#441) * **package:** Update listr to version 0.14.1 ([#445](lint-staged/lint-staged#445)) ([a56d7c9](lint-staged/lint-staged@a56d7c9)), closes [#426](lint-staged/lint-staged#426) * Add .lintstagedrc.js to list of config files to search ([9e27620](lint-staged/lint-staged@9e27620)) </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new file
resolveTaskFnwhich checks and returns different task functions depending on the OS. File paths passed to linters are chunked only on Windows as it is unnecessary everywhere else to the best of my understanding. Also includes some minor refactoring, renaming and docs update.I have not yet added tests, would like to get some feedback first.Closes #430