Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.2.0 can't be installed because index.js is missing #284

Closed
timche opened this issue Sep 15, 2017 · 5 comments · Fixed by #283 or opencomponents/base-templates#128
Closed

v4.2.0 can't be installed because index.js is missing #284

timche opened this issue Sep 15, 2017 · 5 comments · Fixed by #283 or opencomponents/base-templates#128

Comments

@timche
Copy link

timche commented Sep 15, 2017

The latest release v4.2.0 is broken:

npm ERR! path /Users/tim/[...]/node_modules/lint-staged/index.js
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall chmod
npm ERR! enoent ENOENT: no such file or directory, chmod '/Users/tim/[...]/node_modules/lint-staged/index.js'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent 

I think this can only be fixed by releasing a new patch version, which includes the index.js.

CC @okonet

@luftywiranda13
Copy link
Collaborator

See #283, i've proposed a bugfix. Sorry 😢

@timche
Copy link
Author

timche commented Sep 15, 2017

No worries :) I rolled back to 4.1.3 in the meantime. Also didn't see this change in the release changelog.

@luftywiranda13
Copy link
Collaborator

It's just a regular houskeeping I did in #250 (no feature added, no API changed)
I just missed the index.js ✌️ 😞

a new patch version should be released soon!

luftywiranda13 added a commit that referenced this issue Sep 15, 2017
@okonet
Copy link
Collaborator

okonet commented Oct 19, 2017

@luftywiranda13 did you see https://github.com/typicode/pkg-ok? Should we use it or is ESLint rule enough?

@luftywiranda13
Copy link
Collaborator

@okonet it's a nice tool, but I think it's already covered by our ESLint and it's enough. I also think that we barely change our main, bin, and files field, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment