Eror not finding files?

[MrMamen]

      const filenames = files.map(file => file.filename)
                             ^

TypeError: Cannot read property 'map' of undefined
    at sgf (/home/project/web/frontend/node_modules/lint-staged/src/runAll.js:33:30)
    at /home/project/web/frontend/node_modules/staged-git-files/index.js:13:13
    at /home/project/web/frontend/node_modules/staged-git-files/index.js:38:13
    at ChildProcess.<anonymous> (/home/project/web/frontend/node_modules/staged-git-files/index.js:88:9)
    at emitTwo (events.js:125:13)
    at ChildProcess.emit (events.js:213:7)
    at maybeClose (internal/child_process.js:897:16)
    at Socket.stream.socket.on (internal/child_process.js:340:11)
    at emitOne (events.js:115:13)
    at Socket.emit (events.js:210:7)

I've simplified the rules in package.json to:

  "lint-staged": {
    "*": [
    ]
  },

but it still gives the same error
I'm using "lint-staged": "4.1.0", "husky": "0.14.3",

[okonet]

Thanks for reporting this. I think we have a regression.

[OmgImAlexis]

Same issue here.

husky > npm run -s precommit (node v8.4.0)

/Users/xo/code/lad/template/node_modules/lint-staged/src/runAll.js:33
      const filenames = files.map(file => file.filename)
                             ^

TypeError: Cannot read property 'map' of undefined
    at sgf (/Users/xo/code/lad/template/node_modules/lint-staged/src/runAll.js:33:30)
    at /Users/xo/code/lad/template/node_modules/staged-git-files/index.js:13:13
    at /Users/xo/code/lad/template/node_modules/staged-git-files/index.js:38:13
    at ChildProcess.<anonymous> (/Users/xo/code/lad/template/node_modules/staged-git-files/index.js:88:9)
    at emitTwo (events.js:125:13)
    at ChildProcess.emit (events.js:213:7)
    at maybeClose (internal/child_process.js:927:16)
    at Socket.stream.socket.on (internal/child_process.js:348:11)
    at emitOne (events.js:115:13)
    at Socket.emit (events.js:210:7)

husky > pre-commit hook failed (add --no-verify to bypass)

[okonet]

I've just merged the fix. Please update to the latest version.

[OmgImAlexis]

@okonet updated and I'm still getting the same issue on OSX.

[sudo-suhas]

@OmgImAlexis Could you share your lint-staged config? If you could help us reproduce this issue in a fresh project that would be very helpful.

Edit: @okonet Looks like there was a problem with semantic-release - https://travis-ci.org/okonet/lint-staged/jobs/272462973#L1966. A new version with the fixes was not released. Only the lodash fix in #265 was released in v4.1.1.

[OmgImAlexis]

  "lint-staged": {
    "*.{js,jsx,mjs,ts,tsx,css,less,scss,json,graphql}": [
      "prettier --write --single-quote --trailing-comma none",
      "git add"
    ],
    "*.md": [
      "remark . -qfo",
      "git add"
    ]
  },

PING: @niftylettuce

[sudo-suhas]

@okonet I identified the issue. The commits were squashed and merged with test: Fix failing tests on Windows (#255) which meant semantic-release thought there were no fixes in the commit.

[luftywiranda13]

but this is strange, i can comfirm that lint-staged v4.1.1 works just fine on my macbook.
I tested on small projects and also big projects

[okonet]

@sudo-suhas okay let's release them as a part of a separate PR please.

[sudo-suhas]

It is actually an edge case where staged-git-files returns an error. Once scenario where this might happen is if the directory was not a git repository. But in such cases, the error should be propagated instead of breaking lint-staged.

[okonet]

I'm not sure @sudo-suhas since we had issues related to sgf failing with this error before but I didn't see this issue yet.

[sudo-suhas]

If you see the stack trace carefully, you'll notice that the line number in staged-git-files when this error occurred was 38 which is an error callback. Which means we did not handle the error being returned by staged-git-files correctly. This was fixed though, just needs to be released.

let's release them as a part of a separate PR please.

I am not clear on what you mean. Could you please clarify?

[luftywiranda13]

@sudo-suhas okay let's release them as a part of a separate PR please.

empty commit should be fine, right? just to trigger semantic-release to release a patch release

[okonet]

Fix is on the way!