Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request]: Don't show install message if lint-staged is already configured #192

Closed
iamstarkov opened this issue Jun 12, 2017 · 7 comments

Comments

@iamstarkov
Copy link

it doesnt make sense to install in CI, so it would be nice to skip installation in ci, like husky does
https://travis-ci.org/nordnet/grid/jobs/241978766#L176

@okonet
Copy link
Collaborator

okonet commented Jun 12, 2017

Totally agree! It would be awesome if you could create a PR that implements this.

@iamstarkov
Copy link
Author

It seems like you dont actually do any install. its just a greeting message. https://github.com/okonet/lint-staged/blob/master/package.json#L9

@iamstarkov
Copy link
Author

its confusing

@okonet
Copy link
Collaborator

okonet commented Jun 12, 2017

I think you're right and it's worth removing it. The only concern I have is that people who will install it for the first time won't get any message at all. I have a plan on how to improve this and I'll keep this issue in mind.

@iamstarkov
Copy link
Author

iamstarkov commented Jun 12, 2017

i thought people read projects' README before they install, so if they npm install lint-staged they have an idea how to configure it

@okonet
Copy link
Collaborator

okonet commented Jun 12, 2017

Haha just check out issues ;)

@iamstarkov
Copy link
Author

i know, but i bet its not even 2% of the consumers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants