Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move empty img tag from baseof to modal.js #641

Closed
stp-ip opened this issue Dec 1, 2019 · 2 comments · Fixed by #643
Closed

Move empty img tag from baseof to modal.js #641

stp-ip opened this issue Dec 1, 2019 · 2 comments · Fixed by #643
Assignees
@mpourismaiel
Labels
refactor

Comments

@stp-ip
Copy link
Member

stp-ip commented Dec 1, 2019

Reference: #637
@stp-ip stp-ip added the refactor label Dec 1, 2019
@mpourismaiel
Copy link
Member

We better move the entire modal html block into the js file or create a "template" file for it and import that instead of just dumping it in baseof layout.

@stp-ip
Copy link
Member Author

stp-ip commented Dec 1, 2019

Moving the full modal block into its own modal.html feels cleaner yeah. Great.

@mpourismaiel mpourismaiel mentioned this issue Dec 2, 2019
Merged
@mpourismaiel mpourismaiel self-assigned this Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpourismaiel mpourismaiel

Labels
refactor
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move modal html template to js asset files mpourismaiel/syna
2 participants
@stp-ip @mpourismaiel