Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML in BannerGeneral #2518

Closed
taoeffect opened this issue Jan 17, 2025 · 2 comments · Fixed by #2532
Closed

HTML in BannerGeneral #2518

taoeffect opened this issue Jan 17, 2025 · 2 comments · Fixed by #2532

Comments

@taoeffect
Copy link
Member

taoeffect commented Jan 17, 2025

Problem

Prior to @corrideat's fix in PR #2514 for issue #2513, in commit 4e19087, logging in from scratch as user greg results in a "serious error banner" that has HTML inlined to it:

Image

@corrideat fixed the bug causing the banner to appear, but not the bug causing HTML to appear in the banner instead of being rendered.

Solution

Fix it so that HTML is rendered in the BannerGeneral (e.g. using v-safe-html or whatever).

@corrideat
Copy link
Member

I don't think my PR has anything to do with this, other than it triggered a serious banner error. Bisection identified this as a regression introduced in #2139.

@SebinSong
Copy link
Collaborator

@taoeffect @corrideat I can take care of this issue next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants