Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close proposals when they expire #2373

Closed
dotmacro opened this issue Oct 7, 2024 · 1 comment · Fixed by #2388
Closed

Close proposals when they expire #2373

dotmacro opened this issue Oct 7, 2024 · 1 comment · Fixed by #2388

Comments

@dotmacro
Copy link
Member

dotmacro commented Oct 7, 2024

Problem

On testing, proposals are not closed when they expire. This was tested with a proposal that closed more than two months ago.

expiredProposal

Even though the proposal has expired, the "Change vote" link remains, and works.

expiredProposal--canVote

Even though the proposal has expired, the user can change their vote.

expiredProposal--changedVote

Solution

When proposals expire, they should be closed. This means that:

  • on expirey, proposals should automatically close with STATUS_FAILED or STATUS_PASSED
  • proposals with STATUS_FAILED or STATUS_PASSED should not be able to be voted on by any member
@SebinSong
Copy link
Collaborator

Apparently this error message is the cause of the issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants