Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused method & exception #50

Closed
wants to merge 5 commits into from
Closed

chore: remove unused method & exception #50

wants to merge 5 commits into from

Conversation

uniqueg
Copy link
Collaborator

@uniqueg uniqueg commented Feb 11, 2023 •
edited
Loading

  • Remove method tes.client.HTTPClient.wait() and exception tes.utils.TimeoutError as they are not used in the code
  • Remove corresponding unit tests

Resolves #48

@uniqueg uniqueg linked an issue Feb 11, 2023 that may be closed by this pull request
Method "HTTPClient.wait()" defined but unused #48
Open
@uniqueg uniqueg mentioned this pull request Feb 12, 2023
Merged
@uniqueg
Copy link
Collaborator Author

uniqueg commented Feb 28, 2023

Please make sure to squash and merge this PR 🙏🏻

lbeckman314
lbeckman314 previously approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@lbeckman314 lbeckman314 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cleans up unused functions and imports as expected.

Edit: Ah, best to keep as a user-focused convenience function as a library.

@lbeckman314 lbeckman314 dismissed their stale review March 1, 2023 01:07

The wait functions are used as a library utility.

@uniqueg
Copy link
Collaborator Author

uniqueg commented Mar 1, 2023

Closed, because the method can optionally be used by clients. See #48 for more info.

@uniqueg uniqueg closed this Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbeckman314 lbeckman314 lbeckman314 left review comments

@kellrott kellrott Awaiting requested review from kellrott

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Method "HTTPClient.wait()" defined but unused
2 participants
@uniqueg @lbeckman314