Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Infinite render on country code change #9337

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Fix Infinite render on country code change #9337

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23220f3
Fix Infinite render on country code chnage
JavidSumra Dec 9, 2024
386cd46
Remove console
JavidSumra Dec 9, 2024
ce0c079
Merge branch 'develop' into issues/9336/infinite-render-phonenumber-f…
JavidSumra Dec 9, 2024
be73124
Merge branch 'develop' into issues/9336/infinite-render-phonenumber-f…
JavidSumra Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Form/FormFields/PhoneNumberFormField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ const PhoneNumberFormField = React.forwardRef<HTMLInputElement, Props>(
}
setCountry(phoneCodes[getCountryCode(field.value)!]);
}
}, [setValue]);
}, [field.value]);
shivankacker marked this conversation as resolved.
Show resolved Hide resolved

return (
<FormField
Expand Down
Loading