-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Scroll Issue with Pressure Sores Popup #8400
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The popup now opens far away from the cursor click position.
We could instead attempt to use relative
in parent component and absolute
or sticky
in the Popup's div. This would also eliminate the need of calculations.
Screen.Recording.2024-08-22.at.18.19.49.mov
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
@rithviknishad Thanks for the review, redid the calculations a bit, I think it should be fine now! Do check it out once more |
LGTM |
@gigincg Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
* Fix Scroll Issue with Pressure Sores Popup * Improve Computation to anchor next to the click * remove todo comment from pressure sore component --------- Co-authored-by: Rithvik Nishad <[email protected]>
Proposed Changes
Screen.Recording.2024-08-22.at.6.10.44.PM.mov
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist