Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Headless UI v2 #8260

Merged
merged 19 commits into from
Aug 22, 2024
Merged

Migrate to Headless UI v2 #8260

merged 19 commits into from
Aug 22, 2024

Conversation

khavinshankar
Copy link
Member

@khavinshankar khavinshankar commented Aug 6, 2024

Proposed Changes

@nihal467 no visible ui changes but all the components should be rendered as before

#7849 (comment)

Mentioning the issue here as a reminder: we can work on issue 7849 only after merging this V2 PR

@khavinshankar khavinshankar requested a review from a team as a code owner August 6, 2024 01:40
Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 3:18pm

Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 7b6e2be
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66c756a60ec01500082dc2b0
😎 Deploy Preview https://deploy-preview-8260--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Aug 6, 2024



Test summary

126 0 0 0


Run details

Project CARE
Status Passed
Commit 7b6e2be
Started Aug 22, 2024 3:23 PM
Ended Aug 22, 2024 3:26 PM
Duration 02:59 💡
OS Linux Ubuntu -
Browser Chrome 128

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@nihal467
Copy link
Member

nihal467 commented Aug 6, 2024

@khavinshankar the dropdown behavior has some anima effect and is closing slowly, try to checking for each elements presence post selection from dropdown, might solve the issue, post fixing the cypress, mark it for testing

@nihal467
Copy link
Member

#7849 (comment)

Mentioning the issue here as a reminder: we can work on issue 7849 only after merging this V2 PR.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Aug 14, 2024
Copy link

👋 Hi, @khavinshankar,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Aug 14, 2024
Copy link

👋 Hi, @khavinshankar,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Aug 14, 2024
@github-actions github-actions bot added the stale label Aug 22, 2024
@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Aug 22, 2024
@khavinshankar khavinshankar added reviewed reviewed by a core member and removed needs review labels Aug 22, 2024
@nihal467
Copy link
Member

image

@khavinshankar when we multi-select from dropdown in advance filters and, then click apply, it just closes the dropdown, but that shouldn't be the behavior , it should allow users to use apply button directly

@nihal467
Copy link
Member

conditional approving it, will be opening a new issue to fix the multi-select component mentioned in the previous comment

@gigincg gigincg merged commit 9344783 into develop Aug 22, 2024
59 of 61 checks passed
@gigincg gigincg deleted the headlessui-v2 branch August 22, 2024 16:46
Copy link

@khavinshankar Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed reviewed by a core member tested urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants