-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove lodash #6006
Comments
Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity. |
Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity. |
Keeping the issue opened, as loadash was not removed and only replaced in previous PR |
@sainak are you still working on this? |
@rithviknishad @nihal467 pls assign me this issue |
@tellmeY18 @nihal467 @rithviknishad so here
and similar in other files is my approach right? |
Yup! For casing changes specifically, I'd suggest refactoring the usages to use tailwind's text transform classes instead of JS wherever possible. |
ok understood @rithviknishad |
@rithviknishad @tellmeY18 @nihal467 I have removed all the lodash imports and used custom js functions / properties but these two files
has too many lodash occurences so now how should i handle these two files? |
Hey, the bom.json and fe-sbom.json are autogenerated via a workflow which is listing out the dependencies used in care and care_fe. you can ignore the occurance of lodash inside these 2 files and once it's completely removed from the project we should be able to generate jsons that doesn't have lodash occurences. |
oh okay, then I will just raise PR |
@tellmeY18 @rithviknishad @nihal467 |
No description provided.
The text was updated successfully, but these errors were encountered: