Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Software Update notification badges are overlapping #9039

Closed
2 tasks
samholics opened this issue Nov 7, 2024 · 11 comments · Fixed by #9207
Closed
2 tasks

Software Update notification badges are overlapping #9039

samholics opened this issue Nov 7, 2024 · 11 comments · Fixed by #9207
Assignees

Comments

@samholics
Copy link

Describe the bug
when trying to update software by clicking " check for update" option on profile page, Updated successfully notification comes up even before clicking on update button on the "software update is available" notification. These two overlap each other

Image

link for the video: https://drive.google.com/file/d/1Df4rkPPWFk8yhRX2ddTpln6SmPIwfa8u/view?usp=sharing

To Reproduce
Steps to reproduce the behavior:

  1. Go to profile
  2. Click on '' check for update'
  3. See error

Expected behavior

  • show the update available notification with the update button first.
  • show the notification showing software updated to a newer version after clicking on the update button on the first notification

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@ayushpatil2122
Copy link
Contributor

hey can you assign this issue to me

@SwanandBhuskute
Copy link
Contributor

I would like to work on this issue, pls assign me @samholics

@github-project-automation github-project-automation bot moved this to Triage in Care Nov 8, 2024
@rithviknishad rithviknishad moved this from Triage to Up Next in Care Nov 8, 2024
@bodhish
Copy link
Member

bodhish commented Nov 10, 2024

@ayushpatil2122 if you are working on this issue please create a draft PR

@ANIR1604
Copy link
Contributor

I would like work on this, if that's okay.

@ANIR1604
Copy link
Contributor

@rithviknishad On running the website through - npm run dev, when i go for check of updates its keeps on loading.

@github-actions github-actions bot added needs-triage question Further information is requested labels Nov 14, 2024
@rithviknishad
Copy link
Member

https://github.com/ohcnetwork/care_fe/blob/develop/package.json#L36

You might want to try building and running instead.

@ANIR1604
Copy link
Contributor

@rithviknishad Please check the PR, I had resolved the issue of the notifications overlapping each other.

@ANIR1604
Copy link
Contributor

@rithviknishad I had solved this issue by aligning the processes one by one but its giving error in cypress tests in the file which was not edited or changed by me. I am a new contributor in you org can you please guide.

@Jacobjeevan
Copy link
Contributor

@ANIR1604 Since you deleted the branch, are you still working on this?

If so, you would need to continue on the same branch.

@ANIR1604
Copy link
Contributor

Ok I will raise a new PR from a New Branch.

@ANIR1604 Since you deleted the branch, are you still working on this?

If so, you would need to continue on the same branch.

Ok I will raise a new PR from a New Branch.

@bodhish
Copy link
Member

bodhish commented Nov 25, 2024

@ANIR1604 can you link the PR here?

@github-project-automation github-project-automation bot moved this from Up Next to Done in Care Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment