Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log update- vitals #7290

Closed
1 task
aparnacoronasafe opened this issue Feb 27, 2024 · 22 comments · Fixed by #7380
Closed
1 task

Log update- vitals #7290

aparnacoronasafe opened this issue Feb 27, 2024 · 22 comments · Fixed by #7380
Assignees
Labels
good first issue Good for newcomers

Comments

@aparnacoronasafe
Copy link
Member

Is your feature request related to a problem? Please describe.
In Log updates (Critical round), Vitals section, there is a section to mark details of pain.

Against a region, user can mark scale of pain from 0-5.

Screenshot 2024-02-27 at 3 35 23 PM

Here the text "Low" , "Normal", "High" comes written next to the number.

Describe the solution you'd like

It is not useful to tag pain as "Normal"

Only retain "Low" only at 0 and "High" at 5.

  • remove the appearance of "normal" against 1-4 painscale
@aparnacoronasafe aparnacoronasafe added the good first issue Good for newcomers label Feb 27, 2024
@github-project-automation github-project-automation bot moved this to Triage in Care Feb 27, 2024
@saloni0419
Copy link
Contributor

@aparnacoronasafe can you please assign me this issue

@aparnacoronasafe
Copy link
Member Author

@saloni0419 done!

@saloni0419
Copy link
Contributor

@aparnacoronasafe I have solved the issue, i am not able to push it on Git Hub i am running the command right but on git commit it is showing no filed staged. I have forked, cloned right added a new branch, and git add. , git status. I have done all these still showing the error. Can you please help me
image

@rithviknishad
Copy link
Member

@saloni0419 what does git status and git diff show?

@saloni0419
Copy link
Contributor

@rithviknishad git diff shows nothing and git status shows
image

@rithviknishad
Copy link
Member

Seems weird. Are you in the right directory? 😅

cc: @sainak @Ashesh3

@sainak
Copy link
Member

sainak commented Feb 28, 2024

@saloni0419 it's better to use the integrated terminal or the visual git manager included in your editor

@sainak
Copy link
Member

sainak commented Feb 28, 2024

Most of the problems can be solved with a simple on/off so close your terminal and editor and open them again in the correct path

@saloni0419
Copy link
Contributor

@sainak I have done it I have even reforked it. but I will try to get it in the integrated terminal

@saloni0419
Copy link
Contributor

image
image

i did it again still shows the same issue

@Ashesh3
Copy link
Member

Ashesh3 commented Feb 28, 2024

image image

i did it again still shows the same issue

Can you verify if your changes are still there in the respective files?

@saloni0419
Copy link
Contributor

@Ashesh3 yes I have changed the file but it showing modified husky.sh

@saloni0419
Copy link
Contributor

image
here is the ss of change in UI. i have solved this issue and changed the code

@Ashesh3
Copy link
Member

Ashesh3 commented Feb 28, 2024

image here is the ss of change in UI. i have solved this issue and changed the code

Could you point out the full path of the file you edited in order to make this change? (Entire path /d/...../.../...)

@saloni0419
Copy link
Contributor

D:\Open Source\care_fe\src\Components\CriticalCareRecording\Pain\CriticalCare__PainInputModal.bs.js

@sainak
Copy link
Member

sainak commented Feb 28, 2024

D:\Open Source\care_fe\src\Components\CriticalCareRecording\Pain\CriticalCare__PainInputModal.bs.js

@saloni0419 the above file is generated from src/Components/CriticalCareRecording/Pain/CriticalCare__PainInputModal.res
the issue that you are working on requires changes in rescript files

@Ashesh3
Copy link
Member

Ashesh3 commented Feb 28, 2024

As Aakash said above, you need to make changes to src/Components/CriticalCareRecording/Pain/CriticalCare__PainInputModal.res file, and the same will auto reflect in your preview, then try to git add that file, make the commit and push changes.

@saloni0419
Copy link
Contributor

okay I am doing it

@saloni0419
Copy link
Contributor

I am just new to rescript files and just wanted to know, that I have changed the code in .res file, now how it will reflect the change in js and overall . can anyone please help in this

@Ashesh3
Copy link
Member

Ashesh3 commented Feb 28, 2024

I am just new to rescript files and just wanted to know, that I have changed the code in .res file, now how it will reflect the change in js and overall . can anyone please help in this

Once you've made the changes to the Rescript file (.res), you need to build them

  1. To build them just once you can run npm run build:res (Which runs rescript clean && rescript build)
  2. For a better dev experience, run the rescript builder in watch mode npm run dev:res, this will auto build your .res files as you keep making changes.
  3. After the build, refresh the page if that does not happen automatically and you should see your changes.

To learn more about rescript files: https://rescript-lang.org/

@saloni0419
Copy link
Contributor

I have linked a PR yesterday.
Please review it.

Copy link

github-actions bot commented Apr 1, 2024

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

@github-actions github-actions bot added the stale label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants