Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Clear Indication for Removed Medication In Edit form #11304

Open
abhimanyurajeesh opened this issue Mar 15, 2025 · 3 comments · May be fixed by #11313
Open

No Clear Indication for Removed Medication In Edit form #11304

abhimanyurajeesh opened this issue Mar 15, 2025 · 3 comments · May be fixed by #11313
Assignees
Labels
needs-triage question Further information is requested

Comments

@abhimanyurajeesh
Copy link
Contributor

Describe the bug
Even though the medication has been removed, it still appears as if it hasn’t been removed.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Medication Request'
  2. Click add a Medication and edit.
  3. See issue

Expected behavior
The removed medication should either be displayed with a strikethrough or in a different color to indicate its removal. Additionally, the Edit and Remove buttons should be hidden.

Screenshots
https://github.com/user-attachments/assets/a9227679-0f14-42aa-b1ef-f3fdb9ca15fa

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

🚨 DO NOT EDIT BELOW THIS LINE 🚨

Instructions for Requesting Assignment:

To request assignment, please clearly outline your solution and timeline by commenting on the issue using the format below:

Describe your solution clearly:
Provide a detailed explanation of your proposed solution, including your approach, key implementation steps, and relevant examples or references. Mention any dependencies, assumptions, or risks you foresee that might affect your timeline or implementation.

Expected Timeline:

  • End date: [Expected submission date of a completed Pull Request]

Additional Context:
Include any other relevant context, links, screenshots, or resources that support your proposed solution.

🚨 Your assignment may be unassigned if there is no activity or progress within the stated timeline unless communicated clearly and agreed upon.

@hrit2773
Copy link
Contributor

@abhimanyurajeesh if you are not taking up then can I take it up ETA: 2 days @Jacobjeevan @rithviknishad

@siva222003
Copy link
Contributor

Hey @abhimanyurajeesh,
If you’re not working on this, can I take it up?

Approach:

  • We can add a line-through class to the display name when the medication status is not active.
  • The edit button is currently only visible on small screens. Since both the edit and delete buttons are already disabled, we can either leave them as is or remove them if necessary.

ETA: EOD

Please assign me this @rithviknishad @Jacobjeevan and let me know if there’s anything else to consider.

@github-actions github-actions bot added needs-triage question Further information is requested labels Mar 15, 2025
@abhimanyurajeesh
Copy link
Contributor Author

Yes you may.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants