Skip to content

Fixed content overflow in location page for smaller devices #11314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 19, 2025
Merged

Fixed content overflow in location page for smaller devices #11314

merged 9 commits into from
Mar 19, 2025

Conversation

Spandan-Mishra
Copy link
Contributor

@Spandan-Mishra Spandan-Mishra commented Mar 16, 2025 •
edited
Loading

Proposed Changes

image

Screen.Recording.2025-03-19.195714.mp4

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA in Mobile Devices
  • Completion of QA in Desktop Devices

Summary by CodeRabbit

  • Style
    • Enhanced the facility settings view layout for improved responsiveness and visual clarity.
    • Updated the layout of the add location button for better alignment and spacing.
    • Improved tab management in the settings layout with horizontal overflow handling.

@Spandan-Mishra Spandan-Mishra requested a review from a team as a code owner March 16, 2025 10:49
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 16, 2025 •
edited
Loading

Walkthrough

The LocationView.tsx file was modified to streamline its layout and improve responsiveness. The outer flex container was removed, and the inner container now includes a flex-wrap class to better accommodate content on mobile devices. Badge components were repositioned, and the layout of the add location button was enhanced. Additionally, the layout.tsx file was updated to manage horizontal overflow in the TabsList component, ensuring better responsiveness for tab elements.

Changes

File(s) Change Summary
src/pages/Facility/settings/locations/LocationView.tsx Removed outer flex container; added flex-wrap to inner container; repositioned Badge components; updated layout of add location button.
src/pages/Facility/settings/layout.tsx Updated TabsList class to include overflow handling for better management of tab elements.

Assessment against linked issues

Objective Addressed Explanation
Ensure content remains within container and maintains responsiveness (#11298) ✅

Possibly related PRs

  • fix: Organization Users page needs responsiveness #10413: The changes in the main PR for LocationView.tsx involve layout modifications that enhance responsiveness, while the retrieved PR for OrganizationUsers.tsx also focuses on similar layout adjustments to improve responsiveness, specifically through the use of flex-wrap.

Suggested labels

needs review, tested, changes required

Suggested reviewers

  • Jacobjeevan
  • rithviknishad

Poem

In a garden of code, I hop with glee,
Flex-wrap magic setting the layout free.
Badges and inputs now dance in line,
With every change, the overflow's fine.
Hopping along, I nibble on each refined design! 🥕

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d59e8d2 and 4882d86.

📒 Files selected for processing (2)
  • src/pages/Facility/settings/layout.tsx (1 hunks)
  • src/pages/Facility/settings/locations/LocationView.tsx (3 hunks)
✅ Files skipped from review due to trivial changes (1)
  • src/pages/Facility/settings/layout.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/pages/Facility/settings/locations/LocationView.tsx
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Test
  • GitHub Check: OSSAR-Scan
  • GitHub Check: cypress-run (1)
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify Netlify
Copy link

netlify bot commented Mar 16, 2025 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 9e966b9
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/67dac7ea95727a0009fa30a3
😎 Deploy Preview https://deploy-preview-11314.preview.ohc.network
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

yash-learner
yash-learner approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@yash-learner yash-learner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yash-learner yash-learner added needs testing reviewed reviewed by a core member labels Mar 17, 2025
@yash-learner
Copy link
Member

@Spandan-Mishra Please update the changelog we have made more changes.

@yash-learner yash-learner merged commit 37ed690 into ohcnetwork:develop Mar 19, 2025
16 of 17 checks passed
@github-actions GitHub Actions
Copy link

@Spandan-Mishra Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

@coderabbitai coderabbitai bot mentioned this pull request Mar 20, 2025
Closed
7 tasks
@Spandan-Mishra Spandan-Mishra mentioned this pull request Mar 21, 2025
Closed
This was referenced Mar 23, 2025
Merged
Closed
Merged
@coderabbitai coderabbitai bot mentioned this pull request Apr 6, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yash-learner yash-learner yash-learner approved these changes

Assignees
No one assigned
Labels
needs testing reviewed reviewed by a core member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Content Overflow in location page
2 participants
@Spandan-Mishra @yash-learner