From 3e1960722016e652ca57603a3202dc99b18451b1 Mon Sep 17 00:00:00 2001 From: Rithvik Nishad Date: Wed, 27 Nov 2024 20:38:51 +0530 Subject: [PATCH 1/3] Add gitattributes to enforce proper line endings (#9223) --- .gitattributes | 1 + 1 file changed, 1 insertion(+) create mode 100644 .gitattributes diff --git a/.gitattributes b/.gitattributes new file mode 100644 index 00000000000..2125666142e --- /dev/null +++ b/.gitattributes @@ -0,0 +1 @@ +* text=auto \ No newline at end of file From 532945766d2b76bd64dc4ce7ced9aceedece313d Mon Sep 17 00:00:00 2001 From: Rithvik Nishad Date: Wed, 27 Nov 2024 21:12:10 +0530 Subject: [PATCH 2/3] Fix loading state management in useQuery when requests are aborted (#9222) --- src/Utils/request/request.ts | 3 +++ src/Utils/request/useMutation.ts | 10 ++++++---- src/Utils/request/useQuery.ts | 6 ++++-- 3 files changed, 13 insertions(+), 6 deletions(-) diff --git a/src/Utils/request/request.ts b/src/Utils/request/request.ts index d036ad49750..847b7c9ba60 100644 --- a/src/Utils/request/request.ts +++ b/src/Utils/request/request.ts @@ -70,6 +70,9 @@ export default async function request( return result; } catch (error: any) { result = { error, res: undefined, data: undefined }; + if (error.name === "AbortError") { + return result; + } } } diff --git a/src/Utils/request/useMutation.ts b/src/Utils/request/useMutation.ts index fbc6edc3940..7c368f5e45d 100644 --- a/src/Utils/request/useMutation.ts +++ b/src/Utils/request/useMutation.ts @@ -10,7 +10,7 @@ import { mergeRequestOptions } from "@/Utils/request/utils"; export default function useMutation( route: MutationRoute, - options: RequestOptions, + options: RequestOptions, ) { const [response, setResponse] = React.useState>(); const [isProcessing, setIsProcessing] = React.useState(false); @@ -18,7 +18,7 @@ export default function useMutation( const controllerRef = React.useRef(); const runQuery = React.useCallback( - async (overrides?: RequestOptions) => { + async (overrides?: RequestOptions) => { controllerRef.current?.abort(); const controller = new AbortController(); @@ -31,8 +31,10 @@ export default function useMutation( setIsProcessing(true); const response = await request(route, { ...resolvedOptions, controller }); - setResponse(response); - setIsProcessing(false); + if (response.error?.name !== "AbortError") { + setResponse(response); + setIsProcessing(false); + } return response; }, [route, JSON.stringify(options)], diff --git a/src/Utils/request/useQuery.ts b/src/Utils/request/useQuery.ts index 109ff0bb2f1..5f4c10a289e 100644 --- a/src/Utils/request/useQuery.ts +++ b/src/Utils/request/useQuery.ts @@ -37,8 +37,10 @@ export default function useQuery( setLoading(true); const response = await request(route, { ...resolvedOptions, controller }); - setResponse(response); - setLoading(false); + if (response.error?.name !== "AbortError") { + setResponse(response); + setLoading(false); + } return response; }, [route, JSON.stringify(options)], From 6bea49af43e0cc75f23d4bd1a14bb5a9119a9c9c Mon Sep 17 00:00:00 2001 From: Tanuj Nainwal <125687187+Tanuj1718@users.noreply.github.com> Date: Thu, 28 Nov 2024 10:44:57 +0530 Subject: [PATCH 3/3] updated crowdin.yml file (#9211) Co-authored-by: Tanuj Nainwal --- crowdin.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/crowdin.yml b/crowdin.yml index 0ab1a042711..fdcb6bcd32d 100644 --- a/crowdin.yml +++ b/crowdin.yml @@ -1,5 +1,6 @@ files: - - source: /src/Locale/en/*.json - translation: /src/Locale/%two_letters_code%/%original_file_name% + - source: /public/locale/{{lang}}.json + translation: /public/locale/%two_letters_code%/%original_file_name% bundles: - 2 +