-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: add test to support restart identity and support pgsql-ast-parser@8 #104
tests: add test to support restart identity and support pgsql-ast-parser@8 #104
Conversation
No, master is fine... This project is small so I try too keep things simple. That said, you might try, but you might have some trouble integrating the breaking change that shipped with your PR I mentioned earlier (types & tests wont be happy if you dont). If you cant, that's fine. I dont have the time to do it today, but I will try to do it ASAP, so let me know 😀 |
I'll take a look at it, but probably you will be faster in addressing it. |
I took a look but likely I won't have time to work on it right now, several tests are break. |
Hello! I will not let it in limbo. I'm planning to work on it in the coming weeks. Probably, I'd like a direction from you somehow. I'll figure out the steps to work on it and come back here for feedback. |
58f2d16
to
55c61ac
Compare
Hi, I think that I'm almost done. I just need some help to figure out why the I also don't know if the approach that I did is the best one. |
Hi, this message:
Means that your code has not read the ex: ps: Thanks for working on this 🙂 and sorry for my late replies |
I've seen this approach, however, I'm not sure where I should implement it, can you give me the file with an example? |
This PR aims to support the new feature landed in [email protected]. Shall it be based on
next
instead of master?