From 7f375de450cfa6ffcd2d2dc37396bdd26d110d2a Mon Sep 17 00:00:00 2001 From: Ali Ijaz Sheikh Date: Wed, 17 Jul 2019 15:02:15 -0700 Subject: [PATCH] deps: V8: workaround V8 leak w track constant fields track_constant_fields exposes a large regression in memory leak due to a suspected memory leak. Disable this until a proper fix is ready. Ref: https://bugs.chromium.org/p/v8/issues/detail?id=9507 Ref: https://github.com/nodejs/node/issues/28205 --- common.gypi | 2 +- deps/v8/src/flag-definitions.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common.gypi b/common.gypi index 36e9745009ee44..1eadd779a34427 100644 --- a/common.gypi +++ b/common.gypi @@ -38,7 +38,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.15', + 'v8_embedder_string': '-node.16', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/src/flag-definitions.h b/deps/v8/src/flag-definitions.h index da33cd170d5160..a02861482cfccc 100644 --- a/deps/v8/src/flag-definitions.h +++ b/deps/v8/src/flag-definitions.h @@ -1044,7 +1044,7 @@ DEFINE_IMPLICATION(trace_ic, log_code) DEFINE_GENERIC_IMPLICATION( trace_ic, TracingFlags::ic_stats.store( v8::tracing::TracingCategoryObserver::ENABLED_BY_NATIVE)) -DEFINE_BOOL_READONLY(track_constant_fields, true, +DEFINE_BOOL_READONLY(track_constant_fields, false, "enable constant field tracking") DEFINE_BOOL_READONLY(fast_map_update, false, "enable fast map update by caching the migration target")