[BUGFIX] repeated scrollToRow #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 must have been from my refactoring. My mistake 😝 |
offirgolan
added a commit
that referenced
this pull request
Nov 7, 2016
* master: (42 commits) Resizable column fixes (#252) fix: repeated scrollToRow (#254) chore(package): update ember-cli-code-coverage to version 0.3.7 (#253) Demo Cleanup (#251) chore(package): update ember-lodash to version 0.0.11 (#245) chore(package): update ember-cli-code-coverage to version 0.3.6 (#249) Document `Row#content` (#250) Update resizable snippet Released v1.5.2 [FEATURE] minResizeWidth + Event bubbling fix (#244) Update readme Update readme Released v1.5.1 Add safe checks scroll logic (#241) [DOCFIX] Make breakpoints of demo app the same as ember-responsive's default (#240) Released v1.5.0 Demo + Scrolling Cleanup (#238) [FEATURE] Responsive Columns (#235) [FEATURE] ScrollTo and ScrollToRow (#228) chore(package): update broccoli-asset-rev to version 2.5.0 (#227) ...
offirgolan
added a commit
that referenced
this pull request
Nov 14, 2016
* master: (24 commits) chore(package): update ember-wormhole to version 0.5.1 (#261) Update changelog Released v1.6.0 [FEATURE] Draggable Columns (#258) chore(package): update ember-cli-code-coverage to version 0.3.8 (#257) Resizable column fixes (#252) fix: repeated scrollToRow (#254) chore(package): update ember-cli-code-coverage to version 0.3.7 (#253) Demo Cleanup (#251) chore(package): update ember-lodash to version 0.0.11 (#245) chore(package): update ember-cli-code-coverage to version 0.3.6 (#249) Document `Row#content` (#250) Update resizable snippet Released v1.5.2 [FEATURE] minResizeWidth + Event bubbling fix (#244) Update readme Update readme Released v1.5.1 Add safe checks scroll logic (#241) [DOCFIX] Make breakpoints of demo app the same as ember-responsive's default (#240) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently repeatedly setting the
scrollToRowproperty to the same row doesn't work, because thetargetScrollOffsetisn't properly resetted.This PR fixes that and also removes the unnecessary checks from #241.