[FEATURE] Support horizontal scrolling #222
Conversation
|
@taras I would love your feedback on this one |
|
How complete is this implementation? I guess it just uses regular scrollbar? |
|
Its very naive. It works well but just uses the native scrollbar. |
| @@ -14,13 +14,17 @@ export default Component.extend(InViewportMixin, { | |||
|
|
|||
| didInsertElement() { | |||
| this._super(...arguments); | |||
|
|
|||
| let scrollBuffer = this.get('scrollBuffer'); | |||
There was a problem hiding this comment.
should all these variables be const instead of let, since you're not reassigning the variable name? (noticed this a lot in the repo)
There was a problem hiding this comment.
Added Ember Suave to fix this kind of issues. It says to use let so I'm going with it 😝
There was a problem hiding this comment.
not sure what its deal is, but there's so many variables that aren't being reassigned, that should be const
https://github.com/dockyard/styleguides/blob/master/engineering/javascript.md#assignment
😢
* master: chore(package): update broccoli-asset-rev to version 2.5.0 (#227) chore(package): update ember-data to version 2.9.0 (#230) chore(package): update ember-cli-mirage to version 0.2.3 (#232) Ember Suave + Cleanup (#234) Add label to base column to be used in column types (#221) chore(package): update ember-scrollable to version 0.3.4 (#226)
* master: (24 commits) chore(package): update ember-wormhole to version 0.5.1 (#261) Update changelog Released v1.6.0 [FEATURE] Draggable Columns (#258) chore(package): update ember-cli-code-coverage to version 0.3.8 (#257) Resizable column fixes (#252) fix: repeated scrollToRow (#254) chore(package): update ember-cli-code-coverage to version 0.3.7 (#253) Demo Cleanup (#251) chore(package): update ember-lodash to version 0.0.11 (#245) chore(package): update ember-cli-code-coverage to version 0.3.6 (#249) Document `Row#content` (#250) Update resizable snippet Released v1.5.2 [FEATURE] minResizeWidth + Event bubbling fix (#244) Update readme Update readme Released v1.5.1 Add safe checks scroll logic (#241) [DOCFIX] Make breakpoints of demo app the same as ember-responsive's default (#240) ...
|
Hi, any idea when this PR going to be merged into master ? |
|
I've been waiting on @alexander-alvarez to see if he can find a workable solution using ember-scrollable. Maybe I can release this as a temporary solution until then. |
|
progress has been made... about to attempt to do the double scrolling - alphasights/ember-scrollable#29 |
|
@alexander-alvarez thats great to hear! Looking at the PR, it seems like your solution will take a bit of work and some time until it gets reviewed / merged. I think Im gonna go ahead and merge this so that way there is no real pressure to get a final solution in. |
|
Thanks, it works great and sufficient for our need right now. I look forward to check ember-scrollable solution though. |
|
Actually what I eventually did is setup an event handler for scroll on the body scrollable-content div with jQuery in the didRender hook of my component. I then simply modify the scrollLeft of the .lt-head-wrap to match the scrollLeft of the ".lt-body-wrap .scrollable-content" . It works pretty well, be you need to enable overflow-x:auto on the body content and set an id to the light-table component. |
|
Does it work? I have header and footer fixed both and many th, but I can't scroll and they are overlaping each other. |
|
@meliborn Make sure all your columns specify a |
|
Hi @offirgolan, the horizontal scroll works fine when the element containing the table is narrower than the table, but as soon as the container is wider than the table the table doesn't fill up the container. I guess it would be nice if the table width matches the container width if the container is wider than the table width. |
|
@offirgolan What should I do to enable horizontal scrolling? Can't find any specific code in provided example. |
|
Had to add .table-container. But there is a problem with pagination - it scrolls as well, even with fixed=true. |
|
@meliborn can you open a new issue with some screenshots and maybe a reproduction? |
Conditions: