[8.0] Invoicing on delivery doesn't work with drop shipping

[gurneyalex]

Version affected: 8.0

Steps to reproduce

1. Enable in "Settings -> Sales":
   • Generate invoices after and based on delivery orders
   • Choose MTO, drop shipping... on sales orders lines

Enable in "Settings -> Purchases"

• Manage Dropshipping

1. Check that the product "IMac" has a supplier called "Spark System" and the Drop Shipping route is enabled
2. Create a SO for Camptocamp, one line with iMac, set the route to "Drop shipping" on the line
3. Set "Create Invoice" policy to "On Delivery Order" in the "Other Information" tab and then Confirm the order
4. Run the scheduler
5. Open the procurements and look for the one with Source Document = your Order. Open the related PO
6. Chose "Invoicing control" = "Based on incoming shipments" then confirm and approve your PO

First problem: you can open the reception from the PO, but from your SO, no way to open the related delivery. This is working if you chose another invoice control policy on the SO or the PO (e.g. "On Delivery" in the SO and "Based on generated draft invoice in the PO" allows you to open the delivery from both the PO and the SO) Actually this was wrong a refresh is needed to get it that's all...

1. From the PO, open the incoming shipment and receive the product, then create the invoice by using the button "Create Invoice" at top left corner.

Second problem: you now have 2 supplier invoices, one for Camptocamp (the customer) and one for "Spark System" (the supplier) where you must have one customer and one supplier invoice

[jco-odoo]

The case where you want on delivery both on sales order and purchase orders, we chose not to implement. (The business case where it is relevant seems very small considering the effort having to change the logic to generate two invoices).

[gurneyalex]

OPW-619836 opened

[gurneyalex]

@jco-odoo that's really bad for me as this is exactly the case my customer wants...

[gurneyalex]

@jco-odoo note that we already get 2 invoices with the correct partners, so no logic change is required here. It's just that we want 1 supplier invoice and 1 customer invoice instead of 2 supplier invoices (which is obviously a bug).

[jco-odoo]

If it is really a problem for your client, don't hesitate to create a pull request. It was not meant to be used this way, so I would not consider it a bug.

[gurneyalex]

How can I put this... When there is nothing preventing me to create a configuration which creates obviously wrong results, I tend to think of it as a 🐛

As for the suggestion of creating a pull request, I will probably end up doing so, yes... But getting help from Odoo SA on such cases is one of the reasons why Camptocamp pushes its customers to get an Odoo Enterprise contract, and I do have to say that such answers feel like a bit of a let down... 😞

[ykoon]

@gurneyalex @jco-odoo I found the same issue ;-( , any update if this will be fixed? or any workaround?

[nhomar]

@jco-odoo In what parallel world have 2 supplier invoices is not a Bug?

[jco-odoo]

We will do a warning in v8 not to do this and provide the feature in master. You could create an intermediate dropship location if you want it in v8.

[jco-odoo]

@nhomar I would like to know in which world you get 2 supplier invoices? Maybe there is something to fix still, but I am not getting 2 supplier invoices. I will look into it.

[ykoon]

@jco-odoo FYI we have account_anglo_saxon installed

[gurneyalex]

Answer by Odoo SA Support:

"""
I had a discussion on this issue with our level 2 experts and we came to a conclusion that we chose not to implement it for stable version. We will put a constraint that will show the message that this feature is not available when you have Invoicing Control on purchase as "Based on incoming shipments" and on Sale order Policy as "On Delivery Order" in case of Drop-shipping configured.

Thanks for understanding. As for now I am closing this issue.
"""
I'm not too happy about this.

[jgrandguillaume]

@jco-odoo

Hi,

I'm sorry Jos, but this is clearly a bug. Having a warning message here won't help much (though it'll at least prevent doing something wrong).

I mean, various people will want to invoice on delivery, using drop shipping or not. Saying you didn't design it this way is not a reason, I'm sorry. You provide the "drop shipping" feature, you provide the "invoice on delivery" feature, so I need both to work.

I know it is not a trivial one: you'll need to change both stock_invoice_onshipping and action_invoice_create in stock_account module... But this exactly why we subscribe to OPW... So please, can you change your mind on this one and fix it ?

Thank you in advance,

Joël

[nhomar]

+1 Joel.

How much Enterprises we must have to comply with this kind of features?

[spadae22]

+1

[qdp-odoo]

Hi guys,

saying +1 won't really help here. The reason why we can't fix it properly in v8 is because it needs developments that are beyond the limit of the policy we have for stable: we need to alter the database schema and add, at least, another account.journal field to select where the customer invoice will be created.

Although it's arguable that this issue is more a bug or a lack of feature, we agree on the fact the current situation is problematic. So

• for v8, we will simply forbid this kind of configuration. There's also a workaround that allows you to achieve this in v8: manually create an intermediate location + chained pull rule.
• for master, we will implement it in the right way.

See, we just want to handle this issue the safest way, and there isn't a blocking point in v8 because of there's a workaround... and that workaround will only be necessary while the real fix isn't released.

I hope it's more clear now.

As always, thanks for the contributions and your understanding on this particular point,
Quentin

[spadae22]

I guess my issue is that we invested heavily in v7 , custom modules with Odoo SA. Having the same type of issue , I was told by odony to migrate to v8 since I was not live and it would not be a big deal.. Well 3 months later it turns out the migration WAS a big deal, waiting again to goto v9 to solve another big - issue.... It not that simple

[nhomar]

@qdp-odoo

Your answer is a little more clear, if you read your point is totally different from the position taken by @jco-odoo.

But BTW, why we must develop ourselves a module having enterprise? instead you add a new one on v8.0 that make such change as an extra module (more secure than that almost impossible) and tested since now?.

It means, I understand completely that you can not change db schema, but it can not bring us more work which at the end will be or 1.- a waste of time because you will solve it for master and my module will be deprecated, or 2.- You never solve it as frquently happen because "there is a communitary module that solve it", or 3.- The worst of all, in future somebody in odoo says "it is too complicated, we better remove dropshipping" and we build a fix over something will be deprecated?.

Then... IMHO technically speaking you have the solution, communitary speaking we are testing and using, commercially speaking you have been paid with enterprises... It is a matter of willing not a technical blocking point.

I hope you understand our point also.

Regards.

[qdp-odoo]

Hi,

i just checked with the responsible of the enterprise contracts and we both agree that the only thing covered by it is to restrict to configure both the PO and SO as "invoice-able based on deliveries".

Nevertheless, as i said earlier, this could be a nice feature to have and that's the reason we already started to develop it for master.

Thanks,

[gurneyalex]

Could you point us to the branch where the dev is taking place?

[gurneyalex]

@qdp-odoo @jco-odoo for the record, we have implemented the feature for v8 in an OCA addon. Should you wish to get the source code, you are very welcome.

[jco-odoo]

@gurneyalex It would be really nice if I could get a look at it. We should put into v9 anyways.

[spadae22]

@gurneyalex Hi, could I get the code for the addon for v8?

[gurneyalex]

@spadae22 @jco-odoo check stock_dropshipping_dual_invoice in OCA/stock-logistics-workflow

[spadae22]

@gurneyalex Great! I will check it out. Thanks!