[IMP] pivot: add pivot design panel #7286
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hokolomopo
force-pushed
the
master-pivot-style-panel-adrm
branch
2 times, most recently
from
9c773a6 to
43e832d
Compare
hokolomopo
commented
Oct 9, 2025
Comment on lines
+241
to
249
| export interface PivotStyle { | ||
| numberOfRows?: number; | ||
| numberOfColumns?: number; | ||
| displayTotals?: boolean; | ||
| displayColumnHeaders?: boolean; | ||
| displayMeasuresRow?: boolean; | ||
| } |
There was a problem hiding this comment.
Having everything optional makes it a bit harder to use, we need to do style.displayTotals ?? DEFAULT_PIVOT_STYLE.displayTotals
- It's fine
- rename variables so they are falsy by default (eg.
hideTotalsinstead) - make everything mandatory. Need migration + make json/revisions a bit more heavy
note that 2/3 don't solve everything, it only works for boolean values not really for number values (I don't think we want to add Number.MAX_VALUE or w/e in the JSON)
There was a problem hiding this comment.
I would go for 1, it's fine, especially because as you say 2 and 3 are not perfect :)
hokolomopo
force-pushed
the
master-pivot-style-panel-adrm
branch
3 times, most recently
from
3425061 to
6452753
Compare
This commit adds a new tab "Design" in the pivot side panel, allowing users to customize the appearance of pivot tables. At the moment the panel only allow for the same customization as the arguments of the `=PIVOT()` function. The user can easily edit those settings in the side panel, and can override them in the formula if needed. Task: 5150320
pro-odoo
force-pushed
the
master-pivot-style-panel-adrm
branch
from
6452753 to
38b1220
Compare
pro-odoo
approved these changes
Oct 20, 2025
Comment on lines
+241
to
249
| export interface PivotStyle { | ||
| numberOfRows?: number; | ||
| numberOfColumns?: number; | ||
| displayTotals?: boolean; | ||
| displayColumnHeaders?: boolean; | ||
| displayMeasuresRow?: boolean; | ||
| } |
There was a problem hiding this comment.
I would go for 1, it's fine, especially because as you say 2 and 3 are not perfect :)
robodoo
pushed a commit
that referenced
this pull request
Oct 20, 2025
This commit adds a new tab "Design" in the pivot side panel, allowing users to customize the appearance of pivot tables. At the moment the panel only allow for the same customization as the arguments of the `=PIVOT()` function. The user can easily edit those settings in the side panel, and can override them in the formula if needed. closes #7286 Task: 5150320 Signed-off-by: Pierre Rousseau (pro) <[email protected]>
|
@hokolomopo @pro-odoo staging failed: ci/runbot (view more at https://runbot.odoo.com/runbot/batch/2189588/build/91582663) |
|
robodoo retry |
robodoo
pushed a commit
that referenced
this pull request
Oct 20, 2025
This commit adds a new tab "Design" in the pivot side panel, allowing users to customize the appearance of pivot tables. At the moment the panel only allow for the same customization as the arguments of the `=PIVOT()` function. The user can easily edit those settings in the side panel, and can override them in the formula if needed. closes #7286 Task: 5150320 Signed-off-by: Pierre Rousseau (pro) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit adds a new tab "Design" in the pivot side panel, allowing users to customize the appearance of pivot tables.
At the moment the panel only allow for the same customization as the arguments of the
=PIVOT()function. The user can easily edit those settings in the side panel, and can override them in the formula if needed.Task: 5150320
review checklist