[REF] helpers: remove duplicated helper

Author: LucasLefevre

src/formulas/compiler.ts

@@ -1,6 +1,6 @@
 import { Token } from ".";
 import { functionRegistry } from "../functions/index";
-import { concat, parseNumber, removeStringQuotes } from "../helpers";
+import { concat, parseNumber, unquote } from "../helpers";
 import { _t } from "../translation";
 import { CompiledFormula, DEFAULT_LOCALE, FormulaToExecute } from "../types";
 import { BadExpressionError, UnknownFunctionError } from "../types/errors";
@@ -217,7 +217,7 @@ function compilationCacheKey(
     tokens.map((token) => {
       switch (token.type) {
         case "STRING":
-          const value = removeStringQuotes(token.value);
+          const value = unquote(token.value);
           return `|S${constantValues.strings.indexOf(value)}|`;
         case "NUMBER":
           return `|N${constantValues.numbers.indexOf(parseNumber(token.value, DEFAULT_LOCALE))}|`;
@@ -252,7 +252,7 @@ function formulaArguments(tokens: Token[]) {
         dependencies.push(token.value);
         break;
       case "STRING":
-        const value = removeStringQuotes(token.value);
+        const value = unquote(token.value);
         if (!constantValues.strings.includes(value)) {
           constantValues.strings.push(value);
         }

src/formulas/parser.ts

@@ -1,4 +1,4 @@
-import { parseNumber, removeStringQuotes } from "../helpers/index";
+import { parseNumber, unquote } from "../helpers/index";
 import { _t } from "../translation";
 import { DEFAULT_LOCALE } from "../types";
 import { BadExpressionError, InvalidReferenceError } from "../types/errors";
@@ -110,7 +110,7 @@ function parseOperand(tokens: Token[]): AST {
     case "NUMBER":
       return { type: "NUMBER", value: parseNumber(current.value, DEFAULT_LOCALE) };
     case "STRING":
-      return { type: "STRING", value: removeStringQuotes(current.value) };
+      return { type: "STRING", value: unquote(current.value) };
     case "INVALID_REFERENCE":
       throw new InvalidReferenceError();
     case "REFERENCE":

src/helpers/misc.ts

@@ -6,23 +6,6 @@ import { ConsecutiveIndexes, Lazy, UID } from "../types";
 import { SearchOptions } from "../types/find_and_replace";
 import { Cloneable, DebouncedFunction } from "./../types/misc";
 
-/**
- * Remove quotes from a quoted string
- * ```js
- * removeStringQuotes('"Hello"')
- * > 'Hello'
- * ```
- */
-export function removeStringQuotes(str: string): string {
-  if (str[0] === '"') {
-    str = str.slice(1);
-  }
-  if (str[str.length - 1] === '"' && str[str.length - 2] !== "\\") {
-    return str.slice(0, str.length - 1);
-  }
-  return str;
-}
-
 function isCloneable<T extends Object>(obj: T | Cloneable<T>): obj is Cloneable<T> {
   return "clone" in obj && obj.clone instanceof Function;
 }
@@ -87,6 +70,13 @@ export function getUnquotedSheetName(sheetName: string): string {
   return unquote(sheetName, "'");
 }
 
+/**
+ * Remove quotes from a quoted string
+ * ```js
+ * unquote('"Hello"')
+ * > 'Hello'
+ * ```
+ */
 export function unquote(string: string, quoteChar: "'" | '"' = '"'): string {
   if (string.startsWith(quoteChar)) {
     string = string.slice(1);