Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClassLoader.h is missing includes #319

Open
GDYendell opened this issue Jul 20, 2023 · 3 comments · May be fixed by #383
Open

ClassLoader.h is missing includes #319

GDYendell opened this issue Jul 20, 2023 · 3 comments · May be fixed by #383
Assignees
@GDYendell
Labels
good first issue

Comments

@GDYendell
Copy link
Collaborator 

#include <boost/shared_ptr.hpp>
#include <map>

This works because it is currently only used in places that also have these includes, but it means it can't be compiled in isolation.
@GDYendell GDYendell self-assigned this Jul 20, 2023
@Ohisemega
Copy link

Ohisemega commented Jan 27, 2025 •
edited
Loading

Fixed the issue on my fork - Update Codebase to C++17 Standard.

@GDYendell
Copy link
Collaborator Author

Could you put it in its own PR @Ohisemega? We want to be able to merge these in any order.

@Ohisemega
Copy link

Ok I'll create a new pull request.

@GDYendell GDYendell linked a pull request Jan 30, 2025 that will close this issue
Open
Ohisemega added a commit to Ohisemega/odin-data that referenced this issue Jan 30, 2025
@Ohisemega
Add Required Headers to ClassLoader.h File
4fea6ec 
Add dependency header to ClassLoader.h to allow stand-alone compilation.
Fixes odin-detector#319
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GDYendell GDYendell

Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Main Branch ISSUE:319 Ohisemega/odin-data
2 participants
@GDYendell @Ohisemega