Refactor Build_log module
#98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterDA
force-pushed
the
build-log
branch
2 times, most recently
from
672db73 to
b474c10
Compare
Contributor
|
Starting to review this PR, thanks @MisterDA ! I added a test for a very simple spec file that fails on ZFS (so I presume windows too iiuc) with the expected failure and the spec file -- now I'll look through the code to see why it's not working :)) EDIT: As the original comment points out, this PR currently does not have the fix so the failure is expected, my bad :)) |
MisterDA
changed the title
Build_log file descriptors just after sandbox finishesBuild_log module
Contributor
Author
|
Changed the PR just to refactor the |
tmcgilchrist
approved these changes
Sep 21, 2022
Member
tmcgilchrist
left a comment
tmcgilchrist
left a comment
There was a problem hiding this comment.
Just 2 small fixes on the pattern matches.
Contributor
Author
Applied, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I closed #90 by mistake.
On Windows, one cannot move a directory if it has files opened inside. A similar case occurs with ZFS. Ensure that all
Build_logfile descriptors are closed before promoting the temporary build directory and the log file it contains as definitive build result.We can either ensure that all tailers have finished reading before closing the log file and moving the directory, or pause the tailers and resume reading from the moved log file.
I'm still
strugglingworking on it, it's not easy, I think I always end up in some sort of deadlock where the tailers and theDb_storelayer are waiting on each other reciprocally.There's just a little refactoring before my attempt (that I haven't pushed yet).