Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve compatibility of Google Cloud Functions, req.body is the parsed JSON payload #937

Merged
merged 5 commits into from
Dec 4, 2023

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Nov 30, 2023

Resolves #935

As requested the light solution.

@wolfy1339

Resolves #ISSUE_NUMBER


Before the change?

After the change?

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Nov 30, 2023

@G-Rath PTAL

@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented, or is being fixed label Nov 30, 2023
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Nov 30, 2023

I go to sleep now. You can modify the code as you need. ;)

@wolfy1339 wolfy1339 changed the title fix: handle gcf, verify already provided request.body fix: improve compatibility of Google Cloud Functions, req.body is the parsed JSON payload Dec 2, 2023
@wolfy1339 wolfy1339 merged commit adcfa21 into octokit:main Dec 4, 2023
6 checks passed
@Uzlopak Uzlopak deleted the fix-gcf-light branch December 4, 2023 01:10
Copy link
Contributor

github-actions bot commented Dec 4, 2023

🎉 This PR is included in version 12.0.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Bug Something isn't working as documented, or is being fixed
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: google-cloud-function, can not verify payload
3 participants