Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handles verify error #917

Merged
merged 1 commit into from
Nov 14, 2023
Merged

fix: handles verify error #917

merged 1 commit into from
Nov 14, 2023

Conversation

nickfloyd
Copy link
Contributor

No description provided.

@nickfloyd nickfloyd added the Type: Bug Something isn't working as documented, or is being fixed label Nov 14, 2023
@nickfloyd nickfloyd merged commit 0504ad8 into 9.x Nov 14, 2023
6 checks passed
@nickfloyd nickfloyd deleted the handle-verify-error branch November 14, 2023 22:31
Copy link
Contributor

🎉 This PR is included in version 9.26.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gr2m
Copy link
Contributor

gr2m commented Nov 15, 2023

we have a problem, the build did not work as expected. Compare

https://unpkg.com/browse/@octokit/[email protected]/

and

https://unpkg.com/browse/@octokit/[email protected]/

I feel like we have seen this before. I think @wolfy1339 figured it out in the past? I'm not sure. I know we moved away from pika because of its build problems, but we really need to get this one out correctly

@wolfy1339
Copy link
Member

We also had a patch to fix the package.json before we had switched away from pika.

I think that is what's needed here

@gr2m
Copy link
Contributor

gr2m commented Nov 15, 2023

can you find the patch? 🙏🏼 sorry I've to run in a second and won't be able to help until later today

@gr2m
Copy link
Contributor

gr2m commented Nov 15, 2023

I found this PR that replaces pika with the new build setup, but I don't see a pika patch in the previous setup?
https://github.com/octokit/request.js/pull/584/files

I also looked into the release build for 9.x and it looks good, as if all folders were created correctly:
https://github.com/octokit/webhooks.js/actions/runs/6879227572/job/18710678481#step:5:14

It also worked as expected locally

@nickfloyd
Copy link
Contributor Author

@wolfy1339 Was this it? e178758

@gr2m
Copy link
Contributor

gr2m commented Nov 15, 2023

I tried to just trigger another release and also added an ls pkg/ step for debugging, the files are there, but they are not published.

@gr2m
Copy link
Contributor

gr2m commented Nov 15, 2023

I did revert to 9.26.0 for the 9.x release channel

npm dist-tag add @octokit/[email protected] release-9.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @9.x Type: Bug Something isn't working as documented, or is being fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants