Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: drop NodeJS v10, v12 support + test NodeJS v18 #555

Merged
merged 5 commits into from
Jun 26, 2022
Merged

feat: drop NodeJS v10, v12 support + test NodeJS v18 #555

merged 5 commits into from
Jun 26, 2022

Conversation

wolfy1339
Copy link
Member

@wolfy1339 wolfy1339 commented Apr 27, 2021 •
edited
Loading

BREAKING CHANGE: drop support for NodeJS <= 14

@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Apr 27, 2021
@wolfy1339
Copy link
Member Author

Support is officially ending on April 30 2021
This is another step forward towards ESM

@wolfy1339 wolfy1339 requested a review from gr2m April 27, 2021 21:03
@gr2m
Copy link
Contributor

gr2m commented Apr 27, 2021

Shall we wait until we have other breaking changes lined up? We could create a v10 milestone and assign this PR and other issues/PRs that will require breaking changes, then once we have some more or it becomes a blocker, do the release and include all issues/PRs assigned to the milestone

@wolfy1339
Copy link
Member Author

Of course, that makes sense

@wolfy1339 wolfy1339 added this to the v10 milestone Apr 27, 2021
@gr2m gr2m added the Status: Blocked Blocked by GitHub's API or other external factors label Jun 11, 2021
@gr2m gr2m added the Type: Breaking change Used to note any change that requires a major version bump label Jun 17, 2021
@octokit octokit deleted a comment Jul 13, 2021
@wolfy1339 wolfy1339 mentioned this pull request Jun 25, 2022
Closed
@wolfy1339
feat: drop NodeJS v10 support
e60b1a9 
BREAKING CHANGE: drop support for NodeJS <= 10
@wolfy1339 wolfy1339 changed the title feat: drop NodeJS v10 support feat: drop NodeJS v10, v12 support + test NodeJS v18 Jun 26, 2022
@wolfy1339 wolfy1339 removed this from the v10 milestone Jun 26, 2022
@wolfy1339 wolfy1339 removed the Status: Blocked Blocked by GitHub's API or other external factors label Jun 26, 2022
@wolfy1339 wolfy1339 requested a review from oscard0m June 26, 2022 00:31
@wolfy1339
Copy link
Member Author

Unblocking this as per the discussion in octokit/oauth-app.js#299

oscard0m
oscard0m previously approved these changes Jun 26, 2022
View reviewed changes
@oscard0m
Copy link
Member

Unblocking this as per the discussion in octokit/oauth-app.js#299

@wolfy1339 Maybe we should wait for @gr2m opinion on this? We can probably script this to apply it to all the repos of the org.

timrogers
timrogers previously approved these changes Jun 26, 2022
View reviewed changes
Copy link

@timrogers timrogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely in favour of making this change and releasing it as a breaking version.

If we can find a way to easily apply it to all of the JS repos, that would be amazing 🌟

@timrogers
Copy link

Honestly though, there aren't that many repos, so if it’s going to take hours and hours to automate, it’s probably better to do it manually.

@oscard0m
Copy link
Member

oscard0m commented Jun 26, 2022 •
edited
Loading

Definitely in favour of making this change and releasing it as a breaking version.

If we can find a way to easily apply it to all of the JS repos, that would be amazing 🌟

Honestly though, there aren't that many repos, so if it’s going to take hours and hours to automate, it’s probably better to do it manually.

Once we merge this (so we agree on the changes to replicate), I will tweak my Octoherd script to do so.

I already created the issues with Octoherd and the fix for pika as well: https://github.com/oscard0m/octoherd-script-migrate-pika

@timrogers
Copy link

Nice script! ❤️That makes it so easy across our many repos. Octoherd is very cool!

@oscard0m
Copy link
Member

Octoherd is very cool!

Created by @gr2m, of course :P

@wolfy1339 wolfy1339 dismissed stale reviews from timrogers and oscard0m via 8b37060 June 26, 2022 14:24
@wolfy1339
Copy link
Member Author

I had to force push to rewrite a commit to remove some unrelated changes, so the reviews got cleared 😓

If we're all in agreement, let's get this merged 🎉

@wolfy1339 wolfy1339 requested review from timrogers and oscard0m June 26, 2022 14:54
@wolfy1339 wolfy1339 merged commit e887f05 into master Jun 26, 2022
@wolfy1339 wolfy1339 deleted the drop-node-v10 branch June 26, 2022 17:13
@github-actions
Copy link
Contributor

🎉 This PR is included in version 10.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@wolfy1339 wolfy1339 mentioned this pull request Jun 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timrogers timrogers timrogers approved these changes

@oscard0m oscard0m oscard0m approved these changes

@gr2m gr2m Awaiting requested review from gr2m

Assignees
No one assigned
Labels
Type: Breaking change Used to note any change that requires a major version bump Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wolfy1339 @gr2m @oscard0m @timrogers