Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate usage of tsd to control breaking changes in type Definitions #301

Open
oscard0m opened this issue Oct 8, 2020 · 1 comment
Open

Evaluate usage of tsd to control breaking changes in type Definitions #301

oscard0m opened this issue Oct 8, 2020 · 1 comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR typescript Relevant to TypeScript users only
Projects
JS

Comments

@oscard0m
Copy link
Member

oscard0m commented Oct 8, 2020

We should start by creating a failing test using SamVerschueren/tsd to verify that we actually fixed the problem and to make sure that we won't break it again.

Is this still necessary? Do I create an issue for this? @gr2m

Originally posted by @dominguezcelada in https://github.com/octokit/webhooks.js/issue_comments/705478219
@ghost ghost added this to Inbox in JS Oct 8, 2020
@oscard0m oscard0m added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR typescript Relevant to TypeScript users only labels Oct 8, 2020
@ghost ghost moved this from Inbox to Maintenance in JS Oct 8, 2020
@gr2m
Copy link
Contributor

gr2m commented Oct 26, 2020

this PR introduces tsd to Probot: https://github.com/probot/probot/pull/1389/files. I think it looks pretty great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR typescript Relevant to TypeScript users only
Projects
No open projects
JS
  
Maintenance
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gr2m @oscard0m