Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: ResponseHeaders doesn't have x-accepted-github-permissions #607

Closed
1 task done
jsoref opened this issue Feb 9, 2024 · 2 comments · Fixed by #609
Closed
1 task done

[BUG]: ResponseHeaders doesn't have x-accepted-github-permissions #607

jsoref opened this issue Feb 9, 2024 · 2 comments · Fixed by #609
Labels
released Type: Bug Something isn't working as documented, or is being fixed

Comments

@jsoref
Copy link
Contributor

jsoref commented Feb 9, 2024

What happened?

github/codeql-action#2117 (comment)

Error: codeql/upload-sarif action failed: Resource not accessible by integration

Versions

"@octokit/types": "^12.4.0"

Relevant log output

There basically wasn't any -- that's the problem.

Notes

According to:

https://docs.github.com/en/rest/using-the-rest-api/troubleshooting-the-rest-api?apiVersion=2022-11-28#resource-not-accessible

You can use the X-Accepted-GitHub-Permissions header to identify the permissions that are required to access the REST API endpoint.

The value of the X-Accepted-GitHub-Permissions header is a comma separated list of the permissions that are required to use the endpoint. Occasionally, you can choose from multiple permission sets. In these cases, multiple comma-separated lists will be separated by a semicolon.

That makes this header incredibly valuable to debugging misconfigured workflows. It would be really helpful if it was included in https://github.com/octokit/types.ts/blob/main/src/ResponseHeaders.ts

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jsoref jsoref added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented, or is being fixed labels Feb 9, 2024
Copy link
Contributor

github-actions bot commented Feb 9, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@github-project-automation github-project-automation bot moved this to 🆕 Triage in 🧰 Octokit Active Feb 9, 2024
@kfcampbell kfcampbell removed the Status: Triage This is being looked at and prioritized label Feb 12, 2024
@kfcampbell kfcampbell moved this from 🆕 Triage to 🔥 Backlog in 🧰 Octokit Active Feb 12, 2024
@nickfloyd nickfloyd moved this from 🔥 Backlog to 🏗 In progress in 🧰 Octokit Active Feb 15, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in 🧰 Octokit Active Feb 15, 2024
@octokitbot
Copy link
Collaborator

🎉 This issue has been resolved in version 12.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Bug Something isn't working as documented, or is being fixed
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants