Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: The placeholders are not replaced for the method getEnvironmentPublicKey #437

Open
1 task done
bogdanmanate-kion opened this issue Jun 12, 2024 · 3 comments
Open
1 task done
Labels
Type: Support Any questions, information, or general needs around the SDK or GitHub APIs

Comments

@bogdanmanate-kion
Copy link

What happened?

Calling the getEnvironmentPublicKey should return the public key for a specific environment, instead a 404 error code is returned.
and it can be seen from the error stack that the placeholders for owner and repo are not replaced.
And example can be found here: https://runkit.com/bogdanmanate-kion/666985abdb0e230008ad9ce7

Versions

Octokitjs 20.0.2, Node v18.11.0

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@bogdanmanate-kion bogdanmanate-kion added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Jun 12, 2024
Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@gr2m
Copy link
Contributor

gr2m commented Jun 12, 2024

@gr2m gr2m added Type: Support Any questions, information, or general needs around the SDK or GitHub APIs and removed Type: Bug Something isn't working as documented Status: Triage This is being looked at and prioritized labels Jun 12, 2024
@bogdanmanate-kion
Copy link
Author

bogdanmanate-kion commented Jun 13, 2024

@gr2m Yes, that is the endpoint, "GET /repos/{owner}/{repo}/environments/{environment_name}/secrets/public-key" from what I see in the error log, only the environment_name is replaced. Please have a look at the provided runkit link.

@nickfloyd nickfloyd moved this from 🆕 Triage to 🔥 Backlog in 🧰 Octokit Active Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Support Any questions, information, or general needs around the SDK or GitHub APIs
Projects
Status: 🔥 Backlog
Development

No branches or pull requests

2 participants