Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: getReviews returns in chronological order with no etag update #346

Open
1 task done
KastenMike opened this issue Aug 15, 2023 · 1 comment
Open
1 task done
Labels
hacktoberfest Issues for participation in Hacktoberfest Status: Up for grabs Issues that are ready to be worked on by anyone Type: Bug Something isn't working as documented

Comments

@KastenMike
Copy link

KastenMike commented Aug 15, 2023

What happened?

pullRequests.getReviews returns in chronological order while pullRequests.getAll is reverse chronological. Is there a reason for this?
If you make use of etags and had per_page: 1 but add a new review, the new review would never be found due to 304 errors. Whereas with pullRequests.getAll, the most recent 1 is first and it seems any change triggers all etags to change (re-opening a PR on page 3 seems to trigger page 1 etag to also change)

The fact that getReviews includes decisions and all the comments makes the pagination risk higher. Whereas getComments (which has a sort option) includes only the comments but no review decisions...it wouldn't be so bad if getReviews would return only the review decisions and not all the comments already covered by getComments but still, a sort option would be better if @gr2m knows someone who works on the backend for these API calls

Versions

^15.8.2

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@KastenMike KastenMike added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Aug 15, 2023
@github-actions
Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@nickfloyd nickfloyd moved this from 🆕 Triage to 🔖 Ready in 🧰 Octokit Active Aug 18, 2023
@kfcampbell kfcampbell added Status: Up for grabs Issues that are ready to be worked on by anyone and removed Status: Triage This is being looked at and prioritized labels Aug 24, 2023
@kfcampbell kfcampbell moved this from 🔖 Ready to 🔥 Backlog in 🧰 Octokit Active Aug 24, 2023
@nickfloyd nickfloyd added the hacktoberfest Issues for participation in Hacktoberfest label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Issues for participation in Hacktoberfest Status: Up for grabs Issues that are ready to be worked on by anyone Type: Bug Something isn't working as documented
Projects
Status: 🔥 Backlog
Development

No branches or pull requests

3 participants