[BUG]: getReviews returns in chronological order with no etag update #346
Labels
hacktoberfest
Issues for participation in Hacktoberfest
Status: Up for grabs
Issues that are ready to be worked on by anyone
Type: Bug
Something isn't working as documented
What happened?
pullRequests.getReviews
returns in chronological order whilepullRequests.getAll
is reverse chronological. Is there a reason for this?If you make use of etags and had
per_page: 1
but add a new review, the new review would never be found due to 304 errors. Whereas withpullRequests.getAll
, the most recent 1 is first and it seems any change triggers all etags to change (re-opening a PR on page 3 seems to trigger page 1 etag to also change)The fact that
getReviews
includes decisions and all the comments makes the pagination risk higher. WhereasgetComments
(which has a sort option) includes only the comments but no review decisions...it wouldn't be so bad ifgetReviews
would return only the review decisions and not all the comments already covered bygetComments
but still, a sort option would be better if @gr2m knows someone who works on the backend for these API callsVersions
^15.8.2
Relevant log output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: