Fix new tree deletion #3040
Open
Fix new tree deletion #3040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note that i also tested this in one of our project and i can confirm it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2836
Before the change?
Must supply either tree.sha or tree.content. Request will be rejected if both are presentnullare not serialized, gh received neither ashanor acontentvalue in the tree and that caused the error.After the change?
nullvalue of theshato allow deletion of tree items.Pull request checklist
I made an integration test but running it is a bit of a pain, I noticed there's no CI on my fork and i am opening this PR to get CI runs x)
Does this introduce a breaking change?
Please see our docs on breaking changes to help!