Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong parameter declaration for SliderFloat4 #45

Closed
apessino opened this issue Sep 17, 2014 · 1 comment
Closed

Wrong parameter declaration for SliderFloat4 #45

apessino opened this issue Sep 17, 2014 · 1 comment

Comments

@apessino
Copy link

Function is declared as (imgui.h, 211):

bool SliderFloat4(const char* label, float v[3], float v_min, float v_max, const char* display_format = "%.3f", float power = 1.0f);

but defined as (imgui.cpp, 3469):

bool SliderFloat4(const char* label, float v[4], float v_min, float v_max, const char* display_format, float power) {

Parameter in declaration v[3] should be v[4], obviously (functionality is fine since the array size is basically just a comment, but users might declare v without enough storage space and end up stomping memory).

@ocornut
Copy link
Owner

ocornut commented Sep 17, 2014

Good catch! Thanks!
It is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants