Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unused variable warning in ImGui::EndListBox() #3897

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

fountainment
Copy link
Contributor

This commit fixed an unused variable warning in function ImGui::EndListBox().

Compiler log:

[  0%] Building CXX object External/imgui/CMakeFiles/imgui.dir/imgui_widgets.cpp.o
/home/even/Projects/cherrysoda-engine/External/imgui/imgui_widgets.cpp: In function ‘void ImGui::EndListBox()’:
/home/even/Projects/cherrysoda-engine/External/imgui/imgui_widgets.cpp:6198:18: warning: unused variable ‘window’ [-Wunused-variable]
 6198 |     ImGuiWindow* window = g.CurrentWindow;
      |                  ^~~~~~
[100%] Linking CXX static library ../../lib/libimgui.a

Compiler version: gcc (GCC) 10.2.0
Platform: Linux 5.11.2-1-MANJARO x86_64

@ocornut ocornut merged commit a3ebd16 into ocornut:master Mar 11, 2021
@ocornut
Copy link
Owner

ocornut commented Mar 11, 2021

Thank you. Please note this only happens if your IM_ASSERT macro is defined as empty.

We are going to add a CI task around the existing "extra warnings" tasks to build with IM_ASSERT disabled to increase the visibility of those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants