Add a color flag for symbols

[aiekick]

I need to have a color for symbol, like triangle or bullet different of text, for this particular theme i use :

because the white color with orange bg is not readable, so i need different color for text and symbol in this particular theme.

but i think, this color flag for symbol may be cool and not useless :)

for the moment i have created a color flag "ImGuiCol_Symbol" i used in the two function :

• RenderTriangle
• RenderBullet

because for the moment the color used for symbol is the color flag of the text.

what do you think of it ?

[ocornut]

I think the request (as you define it) is undesirable, Your picture shows the word "Console" in black and that suggests that the change you/we want has nothing to do with Symbols, but rather being able to redefine the main text color depending on the background color.

This is discussed in #1223, #511, #1055

I apologize that I've been delaying this, I believe the style/coloring system needs a focused rework rather than incremental addition of extra enums because the addition of new enums may never end and has the unobvious side-effect that it would actually break code.

If I naively add e.g. ImGuiCol_ButtonText then PushStyleColor(ImGuiCol_Text) here would break. While I'm not against occasional breakage, the amount of possible enums would potentially skyrocket. My intended solution is to have an implicit inheritance tree, where undefined colors inherit from their parent. I may be able to tackle that in the following few months, in the meanwhile you'll need to either use PushStyleCol(ImGuiCol_Text), either use background colors that are usable with the same single text color, add patch your local copy of imgui adding ImGuiCol_ButtonText, ImGuiCol_HeaderText, etc.

[aiekick]

i not speak about the text color, but about what i supposed to be a symbol and not a char.

here the triangle in the combo. if i define a text color as white in the combo, the text in the combo with gray bg will be white ( ok) but the traingle on the bg orange will be also white and here its my problem.

so i have defined a color flag for symbol, like that i can separate text and symbols :)

i have not the problem for button, i modified the color with a pushStyleColor, but for combo, he cant work as i explained because, the color flag used for render triangle is the text color flag :)

in my style i defined my ImGuiCol_Symbol value to be the same as "ImGuiCol_Text value. like that for some controls i can modify symbol color as needed with the pushStyleColor.

[ocornut]

i not speak about the text color, but about what i supposed to be a symbol and not a char.

We are trying to avoid this distinction as icon fonts are commonly used. You can see in your screenshot that you have exactly the same problem with the word "Console" and you manually solved it with PushStyleCol.

Here the triangle in the combo. if i define a text color as white in the combo, the text in the combo with gray bg will be white ( ok) but the traingle on the bg orange will be also white and here its my problem.

I understand, but your problem is that you want to change the color used when displaying something over the orange/button background. Your problem is unrelated to "symvols". ImGuiCol_Symbol doesn't solve the problem in a general manner since you could have a different background for headers and for buttons and then which color should symbol uses?

i have not the problem for button, i modified the color with a pushStyleColor, but for combo, he cant work as i explained because, the color flag used for render triangle is the text color flag :)

You are offering to solve half of the problem for a certain use case and leave other use cases either unsolved either requiring manual intervention. I'm just saying we need to solve this in a more general way, and will solve it eventually and I have an idea of how to get there but it will take some work.

[aiekick]

ok ok :)

[ocornut]

Closing this now. It's a useful use case to keep in mind when redesigning the colors/styles system. Thanks!

[aiekick]

maybe you can define a function callback pointer of the method RenderBullet and RenderArrow. like that we can implement our function ?

[aiekick]

in fact the other issue i opened some days ago (#3798) is related to this (i forgot the original post haha)