Handle flags with multiple inputs without the flag before each input #25
Conversation
withou the flag before each input
|
Thanks for the contribution! Before we can merge this, we need @idandrd to sign the Salesforce.com Contributor License Agreement. |
src/parse.ts
Outdated
| @@ -47,8 +47,10 @@ export class Parser<T extends ParserInput, TFlags extends OutputFlags<T['flags'] | |||
| private readonly raw: ParsingToken[] = [] | |||
| private readonly booleanFlags: { [k: string]: Flags.IBooleanFlag<any> } | |||
| private readonly context: any | |||
| private _currentFlag: Flags.IOptionFlag<any> | null | |||
There was a problem hiding this comment.
also, the convention in oclif code is to use undefined instead of null which avoids the defaulting you do below
There was a problem hiding this comment.
in other words, this should be private currentFlag?: Flags.IOptionFlag<any>
src/parse.ts
Outdated
| @@ -47,8 +47,10 @@ export class Parser<T extends ParserInput, TFlags extends OutputFlags<T['flags'] | |||
| private readonly raw: ParsingToken[] = [] | |||
| private readonly booleanFlags: { [k: string]: Flags.IBooleanFlag<any> } | |||
| private readonly context: any | |||
| private _currentFlag: Flags.IOptionFlag<any> | null | |||
There was a problem hiding this comment.
also, the convention in oclif code is to use undefined instead of null which avoids the defaulting you do below
| }) | ||
|
|
||
| it('flag multiple with arguments', () => { | ||
| const out = parse(['--foo', './a.txt', './b.txt', './c.txt', '--', '15'], { |
There was a problem hiding this comment.
nice job catching this case, I wasn't sure how it would behave
|
I enabled circle to run on forked builds so it should build on the next push. I'm looking into why appveyor is failing, but that is unrelated to this PR. You submitted your last push just before I put a note in about using If you fix the null thing it should trigger a circle build and we can merge this |
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
==========================================
+ Coverage 90.26% 90.39% +0.12%
==========================================
Files 11 11
Lines 298 302 +4
Branches 79 80 +1
==========================================
+ Hits 269 273 +4
Misses 10 10
Partials 19 19
Continue to review full report at Codecov.
|
<a name="3.5.0"></a> # [3.5.0](d1b77f1...v3.5.0) (2018-06-01) ### Features * Handle flags with multiple inputs without the flag before each input ([#25](#25)) ([c636d74](c636d74))
|
Thank you very much! |
What
So far the parser supported flags with multiple inputs only if the flag shows before each input,
so this worked:
MyCli mycmd -i foo -i barbut this didn't:
MyCli mycmd -i foo barWhy
When passing FS paths with wildcards, the paths are parsed by the terminal before they reach the oclif code. so if I type:
MyCli readFiles -i ./files/*.txtthe oclif will actually getMyCli readFiles -i ./files/a.txt ./files/b.txt ./files/c.txtand the command will fail.I needed a way to allow my users to select multiple files in one command, so this functionality was needed.
How
I kept a copy of the last flag parsed. if the next string in argv is not a flag, and the last flag parsed is accepting multiple values, the string will be added as a value for this flag.