fix: fixed case when not calling dependsOn flag

oclif · Apr 9, 2018 · 76c1c5a · 76c1c5a
1 parent 7dbde11
commit 76c1c5a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 6 deletions.
diff --git a/src/validate.ts b/src/validate.ts
@@ -19,13 +19,14 @@ export function validate(parse: { input: ParserInput; output: ParserOutput<any,
 
   function validateFlags() {
     for (let [name, flag] of Object.entries(parse.input.flags)) {
-      if (flag.required && !parse.output.flags[name]) {
-        throw new RequiredFlagError({parse, flag})
-      }
-      for (let also of flag.dependsOn || []) {
-        if (!parse.output.flags[also]) {
-          throw new CLIError(`--${also}= must also be provided when using --${name}=`)
+      if (parse.output.flags[name]) {
+        for (let also of flag.dependsOn || []) {
+          if (!parse.output.flags[also]) {
+            throw new CLIError(`--${also}= must also be provided when using --${name}=`)
+          }
         }
+      } else {
+        if (flag.required) throw new RequiredFlagError({parse, flag})
       }
     }
   }

diff --git a/test/parse.test.ts b/test/parse.test.ts
@@ -415,6 +415,15 @@ See more help with --help`)
   })
 
   describe('dependsOn', () => {
+    it('ignores', () => {
+      parse([], {
+        flags: {
+          foo: flags.string({dependsOn: ['bar']}),
+          bar: flags.string({char: 'b'}),
+        },
+      })
+    })
+
     it('succeeds', () => {
       const out = parse(['--foo', 'a', '-bb'], {
         flags: {