Skip to content
This repository has been archived by the owner on Apr 21, 2022. It is now read-only.

Modify prune to only remove *.d.ts files, not all .ts files #44

Merged
merged 1 commit into from
Jun 18, 2018
Merged

Modify prune to only remove *.d.ts files, not all .ts files #44

merged 1 commit into from
Jun 18, 2018

Conversation

mahnuh
Copy link
Contributor

@mahnuh mahnuh commented Jun 18, 2018

When building a CLI with code scaffolding you might have some necessary .ts template files. At the moment those files would just disappear and the CLI obviously is not able to find the templates.
Removing just the .d.ts files fixes this issue.

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @mahnuh to sign the Salesforce.com Contributor License Agreement.

@codecov
Copy link

codecov bot commented Jun 18, 2018

Codecov Report

Merging #44 into master will decrease coverage by 0.83%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage    34.7%   33.87%   -0.84%     
==========================================
  Files          18       19       +1     
  Lines         631      682      +51     
  Branches      101      106       +5     
==========================================
+ Hits          219      231      +12     
- Misses        388      427      +39     
  Partials       24       24
Impacted Files Coverage Δ
src/tarballs/build.ts 8.79% <ø> (ø) ⬆️
src/tarballs/bin.ts 15.38% <0%> (-24.62%) ⬇️
src/tarballs/index.ts 100% <0%> (ø)
src/tarballs/node.ts 10.2% <0%> (+3.53%) ⬆️
src/log.ts 75% <0%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 482d3a2...ac3bd29. Read the comment docs.

@jdx jdx merged commit a831bdc into oclif:master Jun 18, 2018
@jdx
Copy link
Contributor

jdx commented Jun 18, 2018

thanks for the contribution!

@jdx
Copy link
Contributor

jdx commented Jun 18, 2018

looking at this again, it probably makes sense to just get rid of this. There is any number of reasons why someone might want these files included. We should probably just include them to be safe.

jdx added a commit that referenced this pull request Jun 18, 2018
oclif-bot added a commit that referenced this pull request Jun 18, 2018
<a name="1.13.34"></a>
## [1.13.34](v1.13.33...v1.13.34) (2018-06-18)

### Bug Fixes

* Modify prune to only remove *.d.ts files, not all .ts files ([#44](#44)) ([a831bdc](a831bdc))
* remove prune ([fd25750](fd25750))
@oclif-bot
Copy link
Contributor

🎉 This PR is included in version 1.13.34 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants