fix: return types of error/exit methods

Author: jdx

package.json

@@ -11,26 +11,26 @@
     ]
   },
   "dependencies": {
-    "@oclif/errors": "^1.0.8",
+    "@oclif/errors": "^1.0.9",
     "@oclif/parser": "^3.3.3",
     "debug": "^3.1.0",
     "semver": "^5.5.0"
   },
   "devDependencies": {
     "@oclif/config": "^1.6.17",
     "@oclif/plugin-help": "^1.2.10",
-    "@oclif/plugin-plugins": "^1.1.6",
+    "@oclif/plugin-plugins": "^1.1.8",
     "@oclif/tslint": "^1.1.0",
     "@types/chai": "^4.1.3",
     "@types/mocha": "^5.2.0",
-    "@types/node": "^10.0.3",
+    "@types/node": "^10.0.4",
     "@types/semver": "^5.5.0",
     "chai": "^4.1.2",
     "fancy-test": "^1.0.6",
     "globby": "^8.0.1",
     "mocha": "^5.1.1",
-    "ts-node": "^6.0.2",
-    "tslint": "^5.9.1",
+    "ts-node": "^6.0.3",
+    "tslint": "^5.10.0",
     "typescript": "^2.8.3"
   },
   "engines": {

src/command.ts

@@ -65,10 +65,10 @@ export default abstract class Command {
     }
   }
 
-  exit(code = 0) { Errors.exit(code) }
+  exit(code = 0) { return Errors.exit(code) }
   warn(input: string | Error) { Errors.warn(input) }
   error(input: string | Error, options: {code?: string, exit?: number} = {}) {
-    Errors.error(input, options)
+    return Errors.error(input, options)
   }
   log(message = '', ...args: any[]) {
     // tslint:disable-next-line strict-type-predicates
@@ -101,9 +101,9 @@ export default abstract class Command {
   protected async catch(err: any) {
     if (!err.message) throw err
     if (err.message.match(/Unexpected arguments?: (-h|--help|help)(,|\n)/)) {
-      this._help()
+      return this._help()
     } else if (err.message.match(/Unexpected arguments?: (-v|--version|version)(,|\n)/)) {
-      this._version()
+      return this._version()
     } else {
       try {
         const {cli} = require('cli-ux')
@@ -126,7 +126,7 @@ export default abstract class Command {
     let title = this.ctor.description && help.render(this.ctor.description).split('\n')[0]
     if (title) this.log(title + '\n')
     this.log(help.command(Config.Command.toCached(this.ctor as any as Config.Command.Class)))
-    this.exit(0)
+    return this.exit(0)
   }
 
   protected _helpOverride(): boolean {
@@ -139,6 +139,6 @@ export default abstract class Command {
 
   protected _version() {
     this.log(this.config.userAgent)
-    this.exit(0)
+    return this.exit(0)
   }
 }

src/main.ts

@@ -11,7 +11,7 @@ export class Main extends Command {
   async init() {
     let [id, ...argv] = this.argv
     await this.config.runHook('init', {id, argv})
-    await super.init()
+    return super.init()
   }
 
   async run() {
@@ -39,7 +39,7 @@ export class Main extends Command {
     const HHelp: typeof Help = require('@oclif/plugin-help').default
     const help = new HHelp(this.config)
     help.showHelp(this.argv)
-    this.exit(0)
+    return this.exit(0)
   }
 }
 

yarn.lock

@@ -34,7 +34,7 @@
     call-me-maybe "^1.0.1"
     glob-to-regexp "^0.3.0"
 
-"@oclif/command@^1.4.18", "@oclif/command@^1.4.20":
+"@oclif/command@^1.4.20":
   version "1.4.20"
   resolved "https://registry.yarnpkg.com/@oclif/command/-/command-1.4.20.tgz#7368c9c9f7f596fc8efffd7ec89118feed5203d8"
   dependencies:
@@ -59,6 +59,16 @@
     strip-ansi "^4.0.0"
     wrap-ansi "^3.0.1"
 
+"@oclif/errors@^1.0.9":
+  version "1.0.9"
+  resolved "https://registry.yarnpkg.com/@oclif/errors/-/errors-1.0.9.tgz#6fe3afd8e7683c436df63674550899adec10c81c"
+  dependencies:
+    clean-stack "^1.3.0"
+    fs-extra "^6.0.0"
+    indent-string "^3.2.0"
+    strip-ansi "^4.0.0"
+    wrap-ansi "^3.0.1"
+
 "@oclif/linewrap@^1.0.0":
   version "1.0.0"
   resolved "https://registry.yarnpkg.com/@oclif/linewrap/-/linewrap-1.0.0.tgz#aedcb64b479d4db7be24196384897b5000901d91"
@@ -82,18 +92,18 @@
     widest-line "^2.0.0"
     wrap-ansi "^3.0.1"
 
-"@oclif/plugin-plugins@^1.1.6":
-  version "1.1.6"
-  resolved "https://registry.yarnpkg.com/@oclif/plugin-plugins/-/plugin-plugins-1.1.6.tgz#4e2e89297bfe5e66acbb2b579a3a2904a6c3aab7"
+"@oclif/plugin-plugins@^1.1.8":
+  version "1.1.8"
+  resolved "https://registry.yarnpkg.com/@oclif/plugin-plugins/-/plugin-plugins-1.1.8.tgz#57e3b00039fc0952304f8fa49532f8ff9c1ceaff"
   dependencies:
     "@heroku-cli/color" "^1.1.3"
-    "@oclif/command" "^1.4.18"
+    "@oclif/command" "^1.4.20"
     chalk "^2.4.1"
     cli-ux "^3.4.1"
     debug "^3.1.0"
     fs-extra "^6.0.0"
     http-call "^5.1.1"
-    load-json-file "^4.0.0"
+    load-json-file "^5.0.0"
     npm-run-path "^2.0.2"
     semver "^5.5.0"
     tslib "^1.9.0"
@@ -117,9 +127,9 @@
   version "5.2.0"
   resolved "https://registry.yarnpkg.com/@types/mocha/-/mocha-5.2.0.tgz#b3c8e69f038835db1a7fdc0b3d879fc50506e29e"
 
-"@types/node@^10.0.3":
-  version "10.0.3"
-  resolved "https://registry.yarnpkg.com/@types/node/-/node-10.0.3.tgz#1f89840c7aac2406cc43a2ecad98fc02a8e130e4"
+"@types/node@^10.0.4":
+  version "10.0.4"
+  resolved "https://registry.yarnpkg.com/@types/node/-/node-10.0.4.tgz#130598ee56e9a1210a53f557d64935571f05390d"
 
 "@types/semver@^5.5.0":
   version "5.5.0"
@@ -886,9 +896,9 @@ kind-of@^6.0.0, kind-of@^6.0.2:
   version "6.0.2"
   resolved "https://registry.yarnpkg.com/kind-of/-/kind-of-6.0.2.tgz#01146b36a6218e64e58f3a8d66de5d7fc6f6d051"
 
-load-json-file@^4.0.0:
-  version "4.0.0"
-  resolved "https://registry.yarnpkg.com/load-json-file/-/load-json-file-4.0.0.tgz#2f5f45ab91e33216234fd53adab668eb4ec0993b"
+load-json-file@^5.0.0:
+  version "5.0.0"
+  resolved "https://registry.yarnpkg.com/load-json-file/-/load-json-file-5.0.0.tgz#5b5ef7cb6e1e337408e02fe01fe679ccc0cd18d5"
   dependencies:
     graceful-fs "^4.1.2"
     parse-json "^4.0.0"
@@ -1337,9 +1347,9 @@ to-regex@^3.0.1, to-regex@^3.0.2:
     regex-not "^1.0.2"
     safe-regex "^1.1.0"
 
-ts-node@^6.0.2:
-  version "6.0.2"
-  resolved "https://registry.yarnpkg.com/ts-node/-/ts-node-6.0.2.tgz#e132d530e53173bc6a8c21ea65f64d8b47bc573e"
+ts-node@^6.0.3:
+  version "6.0.3"
+  resolved "https://registry.yarnpkg.com/ts-node/-/ts-node-6.0.3.tgz#28bf74bcad134fad17f7469dad04638ece03f0f4"
   dependencies:
     arrify "^1.0.0"
     chalk "^2.3.0"
@@ -1384,9 +1394,9 @@ tslint-xo@^0.7.0:
     tslint-eslint-rules "^5.1.0"
     tslint-microsoft-contrib "^5.0.2"
 
-tslint@^5.9.1:
-  version "5.9.1"
-  resolved "https://registry.yarnpkg.com/tslint/-/tslint-5.9.1.tgz#1255f87a3ff57eb0b0e1f0e610a8b4748046c9ae"
+tslint@^5.10.0:
+  version "5.10.0"
+  resolved "https://registry.yarnpkg.com/tslint/-/tslint-5.10.0.tgz#11e26bccb88afa02dd0d9956cae3d4540b5f54c3"
   dependencies:
     babel-code-frame "^6.22.0"
     builtin-modules "^1.1.1"