This repository has been archived by the owner on Feb 1, 2022. It is now read-only.
fix: prompt timeout #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
==========================================
+ Coverage 42.59% 43.01% +0.41%
==========================================
Files 13 13
Lines 277 279 +2
Branches 60 60
==========================================
+ Hits 118 120 +2
Misses 136 136
Partials 23 23
Continue to review full report at Codecov.
|
jdx
reviewed
Jun 1, 2018
src/prompt.ts
Outdated
| resolve(data || options.default) | ||
| } | ||
| }) | ||
| setTimeout(() => reject(), options.timeout || 10000) |
There was a problem hiding this comment.
can't you just change this line to setTimeout(() => reject(), options.timeout || 10000).unref()?
oclif-bot
added a commit
that referenced
this pull request
Jun 1, 2018
<a name="4.6.1"></a> ## [4.6.1](v4.6.0...v4.6.1) (2018-06-01) ### Bug Fixes * unref prompt timeout ([#35](#35)) ([1fd35fb](1fd35fb))
|
🎉 This PR is included in version 4.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.