-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyPi links for the README are unreachable #1052
Comments
This is a small problem, but would be nice to solve. If we replace with absolute links, it introduces a new problem: it makes it harder to debug the readmes locally with the grip tool, because it goes to absolute links of existing readmes rather than the new readmes. In turn, this slows improvements of the readmes. I only advocate solving the problem in this issue if we don't introduce this new problem. Perhaps there is a way to solve both at once? |
Fyi this is a known issue of pypi: |
Thank you for the info @trentmc. Then should we add a message in the main README regarding this pypi issue? |
I wouldn't bother. If we can find a fix that works for both, that's ideal. Alas, I don't know of any. |
@trentmc have we ever considered moving the readmes to something like readthedocs.io? Then the main README could just contain a basic description and a link to the readthedocs. Having the READMES moved there would also make for better organisation by topics. The only caveat I see is making sure we are still compatible with the automated readme tests, which I can look into if we decide to follow-up on this. |
Well we could, but then that becomes redundant with our regular docs: docs.oceanprotocol.com / github.com/oceanprotocol/docs. We could potentially add more ocean.py-specific documentation to that. However, in my experience, making changes to that has high overhead, which is not the intention of the READMEs right now. The READMEs are still undergoing churn. At this point in the lifecycle of ocean.py, I don't want to have to update another repo / do another release for every change. Summary of options of what to do, for now:
My recommendation: do (1), ie nothing, and close this issue. We can revisit this later when there is less churn. (>3 mos away) |
Shall we close this issue? (I recommend yes) |
yes. I will close this. |
The main README from ocean.py which contains the links to the flows that can be reproduced with the library cannot be accessed from PyPi page.
Problem
The links for the flows are relative paths from ocean.py folder, instead of HTTP links.
Solution
Replace them with HTTP links from GitHub since this is a public repo.
The text was updated successfully, but these errors were encountered: