Skip to content

Patch cohttp-2.5.2, revert semantic change in Header.replace#16842

Merged
mseri merged 1 commit into
ocaml:masterfrom
mseri:patch-cohttp-2.5.2
Jul 20, 2020
Merged

Patch cohttp-2.5.2, revert semantic change in Header.replace#16842
mseri merged 1 commit into
ocaml:masterfrom
mseri:patch-cohttp-2.5.2

Conversation

@mseri
Copy link
Copy Markdown
Member

@mseri mseri commented Jul 20, 2020

See mirage/ocaml-cohttp#701

Note that 2.5.3 is not being patched since a new minor release will be submitted once mirage/ocaml-cohttp#702 is merged.

Signed-off-by: Marcello Seri marcello.seri@gmail.com

See mirage/ocaml-cohttp#701

Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
@camelus
Copy link
Copy Markdown
Contributor

camelus commented Jul 20, 2020

Commit: c4a5c0f

A pull request by opam-seasoned @mseri.

☀️ All lint checks passed c4a5c0f
  • These packages passed lint tests: cohttp-async.2.5.2-1, cohttp-lwt-jsoo.2.5.2-1, cohttp-lwt-unix.2.5.2-1, cohttp-lwt.2.5.2-1, cohttp-mirage.2.5.2-1, cohttp-top.2.5.2-1, cohttp.2.5.2-1

☀️ Installability check (+7)
  • new installable packages (7): cohttp.2.5.2-1 cohttp-async.2.5.2-1 cohttp-lwt.2.5.2-1 cohttp-lwt-jsoo.2.5.2-1 cohttp-lwt-unix.2.5.2-1 cohttp-mirage.2.5.2-1 cohttp-top.2.5.2-1

🌤️ 1 ignored non-opam files:
  • packages/cohttp/cohttp.2.5.2-1/files/0001-revert-header-change.patch

@mseri mseri merged commit 772dd80 into ocaml:master Jul 20, 2020
@mseri mseri deleted the patch-cohttp-2.5.2 branch July 20, 2020 17:44
@hannesm
Copy link
Copy Markdown
Member

hannesm commented Jul 23, 2020

it may be worth to mark 2.5.2 (and 2.5.3) as available: false to avoid users installing these versions where the semantics of Header.replace were changed

@mseri
Copy link
Copy Markdown
Member Author

mseri commented Jul 23, 2020

Sure, I'll send a separate pr for those

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants