Add a test for the size of module type of expressions
#1042
Conversation
jonludlam
force-pushed
the
module-type-of-test
branch
2 times, most recently
from
b89ea11 to
14043d8
Compare
jonludlam
force-pushed
the
module-type-of-test
branch
from
14043d8 to
ec56b83
Compare
jonludlam
added
the
no changelog
Julow
left a comment
Julow
left a comment
There was a problem hiding this comment.
I have some small comments but otherwise looks good.
| @@ -0,0 +1,13 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
I guess this file wasn't meant to be there ? Otherwise, compile.sh and odoc.sh shouldn't be included.
There was a problem hiding this comment.
After all, I find gen.sh more readable than the full test.
It could even be inlined in run.t, generating compile.sh and odoc.sh wouldn't be necessary as commands could be called directly in the loop.
There was a problem hiding this comment.
It's there in case we ever wanted to increase the size of the test, or modify the contents of the mli files. I wrote it to do this test so I thought I might as well include it :-)
| @@ -0,0 +1,16 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
That's not a portable #! line. I suggest not having one and to run this script using bash ./compile.sh.
There was a problem hiding this comment.
Huh? I don't understand - I think this script is pretty portable. The gen.sh needs to be changed to #!/bin/bash though!
There was a problem hiding this comment.
The most portable is #!/usr/bin/env bash but it's not perfect. /bin/bash is definitely not portable, it doesn't work on my machine.
It's trivial to do without this line so I think we should do that.
There was a problem hiding this comment.
it doesn't use /bin/bash, it's /bin/sh - does that not work on your machine?
|
Closing in favour of #1079 |
3 participants
No description provided.