Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn when two input produce same output (and overwrite) #250

Open
ygrek opened this issue Jul 17, 2017 · 1 comment
Open

warn when two input produce same output (and overwrite) #250

ygrek opened this issue Jul 17, 2017 · 1 comment

Comments

@ygrek
Copy link

ygrek commented Jul 17, 2017

See ocaml/oasis#114

@gasche
Copy link
Member

gasche commented Jul 17, 2017

Thanks. I think that an ocamlbuild-side solution would be interesting, because ocamlbuild has a better view of intermediate targets than oasis can have (without reverse-engineering the build process). A warning to start with is appropriate, because I would not be surprised if racy file production actually happened in some externally-valid ocamlbuild runs today that people would not like to see breaking. (Of course it's better if rules are rewritten to not be racy, and we could consider making this a failure in the future.)

I think that another failure mode that is silent today (while it looks pretty bad) is for a rule with multiple static outputs to actually not produce one of the target. It may or may not make sense to check for this error in the same style as we check for overridden files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants