Skip to content

fix: properly ignore bigarray if it shouldn't exist #9076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2023
Merged

fix: properly ignore bigarray if it shouldn't exist #9076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changes/9076.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Correctly ignore `bigarray` on recent version of OCaml (#9076, @rgrinberg)
7 changes: 6 additions & 1 deletion src/dune_rules/lib.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1815,7 +1815,12 @@ module DB = struct
| Error e ->
(match e with
| Invalid_dune_package why -> Invalid why
| Not_found when has_bigarray_library && Lib_name.equal name bigarray ->
| Not_found when (not has_bigarray_library) && Lib_name.equal name bigarray
->
(* Recent versions of OCaml already include a [bigrray] library,
so we just silently ignore dependencies on it. The more
correct thing to do would be to redirect it to the stdlib,
but the stdlib isn't first class. *)
Ignore
| Not_found -> Not_found))
~all:(fun () ->
Expand Down